IE replace text selection with keypress #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: * After creating a textbox, selecting text, and pressing a key, the first character of the previous text would remain. * This happened because the hidden textarea would not update its selection in IE when it was in the same parent element as the canvas. This change addresses the need by: * Keeping the hidden textarea in the body element. * IE now correctly updates the text selection as the user interacts with the canvas textbox.
This was referenced Mar 14, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
This change addresses the need by:
Behavior in IE 11 before this change:
Behaviour in IE 11 after this change:
closes #2451