Fixes StaticCanvas.onBeforeScaleRotate not triggering when canvas is zoomed #4748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! try with
and then commit/push again |
|
Would be nice to add a small test |
|
If there are no test examples with event generation i ll help, but i think there is something around. |
|
Took me an hour to figure out where, how and what to test. Let me know if there are any changes. Will do it tomorrow. First time took me a lot of time. Shouldn't take long next time. |
|
I have another doubt: shouldn't onBeforeScaleRotate be member of Canvas instead of StaticCanvas? |
|
definetely. but do not worry to change it now, is a potentially dangerous change for which may be test missing. |
asturur
reviewed
Feb 20, 2018
|
|
||
| canvas.zoomToPoint({ x: 0, y: 0 }, 1); | ||
| canvas.onBeforeScaleRotate = _onBeforeScaleRotate; | ||
| }); |
|
Is good, thanks for the test, is extensive and well written. |
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
…zoomed (fabricjs#4748) * Fixed StaticCanvas.onBeforeScaleRotate not getting triggered when canvas is zoomed. * Added test for Canvas._beforeTransform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4746