isEqual fails hard. #4949
Merged
isEqual fails hard. #4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from base fabric master
|
So i added tests to your branch executing the bug you are fixing for arrays and objects, and indeed the array tests pass, while the object tests fails, |
|
@asturur Thanks for adding a test. Sure will take a look to fix the object case. |
|
Everything passed locally !!! |
|
So why it was going locally no idea. The test was actually catching a bug, calling null is of type Object and Object.keys(null) fails. |
Merged
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
* fix current value null issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: - #4950
small description.
stateful mixin method
isEqualthrow an exception when it tries to compare an array value with null.