Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support <script type=module> minification #1085

Open
mathiasbynens opened this issue Jan 12, 2021 · 1 comment
Open

Support <script type=module> minification #1085

mathiasbynens opened this issue Jan 12, 2021 · 1 comment

Comments

@mathiasbynens
Copy link
Collaborator

html-minifier currently seems to leave <script type="module"> contents intact. It could be that #1046 is sufficient to resolve this.
mathiasbynens added a commit to mathiasbynens/covid-19-vaccinations-germany that referenced this issue Jan 12, 2021
@mathiasbynens
Use non-module frappe-charts so that HTML gets minified properly
ef86e92 
html-minifier currently leaves <script type="module"> contents intact:
kangax/html-minifier#1085 Until that is fixed,
let’s stick to the non-module version.
@DanielRuf
Copy link

This is resolved in https://github.com/terser/html-minifier-terser which also supports ES6 through terser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mathiasbynens @DanielRuf