-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lowercase doctype #822
Comments
Does the current behaviour cause failure in any major browsers? |
No It's just a compression suggestion to shave a few bytes when gzipped |
Unless there is comprehensive proof that nothing breaks and there is a general reduction in gzip sizes across a representative sample, I'm reluctant for any code changes. |
@alexlamsl: you should revisit this. Lowecase |
@XhmikosR I shall take your word on compatibility 😉 Will put together a PR after my belated 🎂 party. |
Hey, it's no my word, it's the community's word ;) You can never beat such extended testing. |
Speaking of community... https://stackoverflow.com/questions/7020961/uppercase-or-lowercase-doctype
According to the discussions above, if we go for uppercase, everything works - otherwise something might break. |
But when the option to use the HTML5 doctype is enabled, then that case isn't valid, is it? Or maybe I'm missing something in regards to XHTML since I've never had the need to use such thing. |
FWIW I can confirm that in my use case, for minified static (GZIPPed) HTML pages, using "doctype" lowercase does save bytes in the compressed/transferred result. If I wanted XHTML output then all sorts of other optimisations would have to go away too, such as dropping optional closing tags and element* quoting. [Edit: * I meant attribute value, sorry!] |
@XhmikosR they mentioned something along the lines of XHTML5 @DamonHD thanks for the observation and the point about optional tags I was worried about those enterprisy (read: Java) libraries getting upset about conformance issues, but you guys have successfully convinced me otherwise. Will put that PR together when I get home. |
Currently, the
useShortDoctype
option rewrites doctypes to uppercaseHTML5 Boilerplate uses lowercase doctype for several years already, there's not much complaints other than incompatibility with XHTML
h5bp/html5-boilerplate#1522
The text was updated successfully, but these errors were encountered: