Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix config file: "html5" and "includeAutoGeneratedTags" were ignored #1090

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

fix config file: "html5" and "includeAutoGeneratedTags" were ignored #1090

wants to merge 1 commit into from

Commits on Apr 14, 2021

  1. fix config file: "html5" and "includeAutoGeneratedTags" were ignored 

    the fix for kangax#860 enabled disabling these 2 flags from the command line
but also made them uncontrollable from the JSON config file

old commander.js (not 2021 commander.js) assigns boolean true
unconditionally as defaultValue for all --no- arguments, when minifier
fuses command line and JSON config file options together in cli.js's
createOptions(), it sees program["includeAutoGeneratedTags"] = true and
ignored config["includeAutoGeneratedTags"], in my case "= false". Delete
the defaultValue/key from commander.js object before parsing user's ARGV
to solve the bug.
    @bulk88
    bulk88 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    bec6f42 View commit details
    Browse the repository at this point in the history