fix whitespace between comments followed by tags #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -796,6 +796,21 @@ | |||
| buffer.length = Math.max(0, index); | |||
| } | |||
|
|
|||
| function squashTrailingWhitespace(nextTag) { | |||
There was a problem hiding this comment.
Could you please add a comment as to what "squash" means here (since it's kind of ambiguous).
|
@kangax added comment and rebased - I hope it's not too confusing for you, and I welcome any suggestion to make the text clearer... |
| // element which has now been removed | ||
| function squashTrailingWhitespace(nextTag) { | ||
| var charsIndex; | ||
| if (buffer.length > 1 && /^(?:<!|$)/.test(buffer[buffer.length - 1]) && /\s$/.test(buffer[buffer.length - 2])) { |
There was a problem hiding this comment.
LGTM but after shortening this line (let's try to keep length <80)
trailing whitespace combined with start tag
even when removeComments is turned off
alexlamsl
added a commit
that referenced
this pull request
Mar 2, 2016
fix whitespace between comments followed by tags
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run into this whilst fixing #499 - I'll let the tests speak for itself 👻