Omit auto-generated tags #540
Conversation
| @@ -1962,6 +1962,22 @@ | |||
| equal(minify(input, options), output); | |||
| }); | |||
|
|
|||
| test('ignore synthetic tags', function() { | |||
| equal(minify('<p id=""class=""title="">x', { ignoreSyntheticTags: true }), '<p id="" class="" title="">x'); | |||
There was a problem hiding this comment.
How would the output be different with ignoreSyntheticTags: false?
There was a problem hiding this comment.
It'd add </p> - I'll add a further test for clarification.
There was a problem hiding this comment.
Thanks. Yeah, it's not really intuitive to me what syntheticTags mean. Could we perhaps say autoGenerated or autoClosing? Or is "synthetic" the actual term from the spec?
There was a problem hiding this comment.
I made that term up, and I'm notoriously bad at naming things 😅
autoGenerated sounds generic enough for possible further expansion - though in this case the default would be true, i.e. it'd be the opposite sense to the current setting. Is that okay?
There was a problem hiding this comment.
how about includeAutoGeneratedTags that's true by default?
options has been deprecated
|
@kangax flag (and commit message) renamed, tests added |
Implemented an option to suppress synthetic tags generated by
htmlparserfrom showing up in the minified output.While it is useful for the parser to generate these signals for minifier to work within the correct context, they do have the effects of breaking browser hacks and other intentional markup omissions.
As it is guarded behind
ignoreSyntheticTagsand is turned off by default, we should be backward-compatible.Also take out
cleanAttributesfrom tests since the option no longer exists.