-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace jscs & jshint with eslint #554
Conversation
Great work! Only issue is with the format you went with for eslintrc. I'm used to the json. Also, are you sure the recommended ones don't conflict with the custom rules you added? Generally, I just specify what I need, but if we can make this cleaner I'm all for it as we keep things simple. Having to go through all of those rules is a p.i.t.a. :/ |
Ah okay. I run into trouble and take note from Node.js and went with yaml, and all of those are generated by Let me start again with JSON with just |
@XhmikosR right, 3rd try at this... forced push and with very minimal |
@@ -0,0 +1,17 @@ | |||
{ | |||
"env": { | |||
"browser": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest that we specify the environment where needed and not globally.
@alexlamsl: apart from my comment, I'd go with |
No worries, it's a minor thing. 👍 |
Turns out what I meant was |
Hmm, I'm confused - the test passed on my machine but not on Travis... |
So I'll chalk that up as |
replace jscs & jshint with eslint
👍 |
@XhmikosR as per request, this is the migration to
eslint
.As I'm completely new to this module,
.eslintrc.yml
is generated usingeslint --init
and feeding it the source files of this project, plus a few minor edits.