Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom color option for cards #396

Merged
merged 3 commits into from
Oct 28, 2023

Conversation

Khusyasy
Copy link
Contributor

Pull request

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Did you lint your code locally before submission?
  2. Did you test your feature thoroughly to ensure there are no bugs?
  3. Does your feature introduce breaking changes?

Please describe your changes

  • add feature card custom color selection
  • add new color selection for custom color in the card edit modal
  • in Card component, if the selected color starts with '#', use css style background-color and use getContrast for the text color

Additional context

Resolves #308

@trobonox trobonox self-requested a review October 28, 2023 14:44
Copy link
Member

@trobonox trobonox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice touch that you also considered the contrast calculation :)

@trobonox
Copy link
Member

Thanks for your contribution, just tested it and it works great!

For the future just a little thing: my branch protection rules require all contributors to sign their commits. For now it's no big deal and I will merge this anyways, but if you want to commit again at some point or contribute to some bigger project maybe consider adding a GPG key and signing your commits :)

@trobonox trobonox merged commit 391d02f into kanriapp:main Oct 28, 2023
@Khusyasy
Copy link
Contributor Author

I see thank you so much, I will consider setting GPG key and signing commits from now on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom RGB colors for cards
2 participants