Add latest go version with missing go version #104
Conversation
|
@karalabe Could you please quick review and merge into master? thanks |
docker/go-1.10/Dockerfile
Outdated
| @@ -0,0 +1,17 @@ | |||
| # Go cross compiler (xgo): Go 1.10 | |||
There was a problem hiding this comment.
Please rename this folder to go-1.10.0 to keep it consistent with the other images.
docker/go-latest/Dockerfile
Outdated
| @@ -3,6 +3,6 @@ | |||
| # | |||
| # Released under the MIT license. | |||
|
|
|||
| FROM karalabe/xgo-1.9.x | |||
| FROM karalabe/xgo-1.10 | |||
There was a problem hiding this comment.
Please use xgo-1.10.x here and create the appropriate file too.
docker/go-1.10/Dockerfile
Outdated
| MAINTAINER Péter Szilágyi <[email protected]> | ||
|
|
||
| # Configure the root Go distribution and bootstrap based on it | ||
| ENV GO_VERSION 110 |
There was a problem hiding this comment.
This version number will blow up, because it would cause 1.10 (110) to be < 1.5 (150). Can't say what the nicest solution would be. Perhaps we could go with 1100?
There was a problem hiding this comment.
I built it locally with GO_VERSION set to 1100. Its not pretty but it works.
docker/go-latest/Dockerfile
Outdated
| @@ -3,6 +3,6 @@ | |||
| # | |||
| # Released under the MIT license. | |||
|
|
|||
| FROM karalabe/xgo-1.9.x | |||
| FROM karalabe/xgo-1.10.0 | |||
There was a problem hiding this comment.
Please use xgo-1.10.x here and create the appropriate file too.
There was a problem hiding this comment.
@karalabe Done. Please review again
|
Thank you very much for this! Merged with some tiny polishes. Will reconfigure docker hub for them. |
Added
Those will fixed #103 #99