Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve HTML report loading performance #2194

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

jkeys089
Copy link
Contributor

@jkeys089 jkeys089 commented Nov 26, 2022

Description

This PR improves the loading performance for HTML reports.
Anecdotally, our largest features would refuse to load even after 20 minutes. After this change, they load in 5-10 seconds.

There are three main areas of improvement:

  1. use vanilla JS in hot paths (since jQuery can sometimes be a bit slow)
  2. utilize event delegation to avoid adding unneeded event listeners
  3. defer loading / processing wherever possible (specifically, when identifying step child nodes during toggling and loading image comparison diff UI options lazily)

@ptrthomas ptrthomas merged commit 97ee4ad into karatelabs:develop Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants