-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce compatibility with recent zigpy changes and improve UART reset stability #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rial port open" This reverts commit d61a42b.
With these changes, I am able to get ZHA running with a nRF52840 stick and have migrated a functional test network to the ZBOSS radio. It continues to work fine and I can control devices. Commands, however, are inconsistent and sometimes have multi-second delays. |
puddly
changed the title
API cleanup and fixes
Introduce compatibility with recent zigpy changes and improve UART reset stability
Jun 21, 2024
@DamKast Let me know if there's anything else I can do to get this PR merged. |
I am sorry it took so much time. Thanks a lot for the updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly large and disorganized PR to get the radio library working with zigpy-cli and ZHA. Main changes are:
probe
, as zigpy now handles this by trying toconnect
.node_info.model
andnode_info.manufacturer
.api.reset()
working properly by internally handling reconnection to the UART.reset
,form
, thenbackup
should erase the old network completely and form a new one with random settings.reset
andform
again will erase them, like before.restore
should bring back the old settings exactly:diff backup1.json backup2.json
should differ only by thebackup_time
and NWK frame counter, everything else should be identical.A few things are left:
zboss.types.basic
, etc. withzigpy.types.basic
: we want all radio libraries to use zigpy types wherever possible.pre-commit
hooks so that auto code formatting works again.This radio library is looking really nice, the ZBOSS serial protocol and command set looks extensive and well-designed!