make it possible to disable whitespace cleanup #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whitespace cleanup can be useful, but it can also be dangerous. Users won’t be aware that something like this is happening, so it might lead to confusion or even data loss in rare cases. For example, if this view is added to an app that had a normal password field before and users already have passwords set up that happen to have leading or trailing whitespace, they won’t be able to log in after an update if they’re copying the password from some other place. For this reason, I think it’s reasonable to let the developer at least opt out of this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whitespace cleanup feature can be useful, but it can also be dangerous. Users won’t be aware that something like this is happening, so it might lead to confusion or even data loss in rare cases. For example, if this view is added to an app that had a normal password field before and users already have passwords set up that happen to have leading or trailing whitespace, they won’t be able to log in after an update if they’re copying the password from some other place.
For this reason, I think it’s reasonable to let the developer at least opt out of this feature.