Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolify #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Rolify #3

wants to merge 4 commits into from

Conversation

yanick
Copy link

@yanick yanick commented Oct 1, 2015

Hi!

I did terrible, terrible things to your module. :-) As we discussed previously, I had a stab at splitting its generic functionality in roles I could re-use for Test::HTTP::Thin::UserAgent

I created two roles, Test::WWW::UserAgent::MockResponses and Test::WWW::UserAgent::History, that take care of those two pieces of functionality that the main module was providing. Beside that, and creating Moo attributes for the attributes that were stashed in the object's hashref, I didn't do much. And, surprinsingly enough, the tests are passing!

@karenetheridge
Copy link
Owner

Did you see the bits I did in the topic/role branch?

@yanick
Copy link
Author

yanick commented Oct 1, 2015

Gah! No, I didn't see you started the work in that branch. Silly me. >.<

Role::Tiny vs Moo. Yeah, I went with R::T at first, then kinda went "aaah, why not go full M on it?" Not that I care that much one way or the other. Didn't find that Moo overcomplicated things too much, but the lack of attributes won't be too much of a pain here. It's your module, so whatever you want, it is Law. :-)

@karenetheridge
Copy link
Owner

Gah! No, I didn't see you started the work in that branch. Silly me. >.<

I didn't go very far (not to the point of it working, at least).. so there may be not much of use in there... :)

@yanick
Copy link
Author

yanick commented Oct 2, 2015

All in all, we pretty much went the same route. I'll try to tweak my patch to use Role::Tiny and change the modules to fit your names tomorrow, and will poke you back then. :-)

@yanick
Copy link
Author

yanick commented Oct 2, 2015

No mo' Moo
Roles renamed to your pattern.

@karenetheridge karenetheridge self-assigned this Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants