Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Node 10 as a minimum version #118

Closed
birtles opened this issue Jul 14, 2020 · 1 comment · Fixed by #119
Closed

Require Node 10 as a minimum version #118

birtles opened this issue Jul 14, 2020 · 1 comment · Fixed by #119
Labels

Comments

@birtles
Copy link
Collaborator

birtles commented Jul 14, 2020

#117 is failing CI because it requires Node 10 but we run CI with Node 8 + stable.

Node 8 reached EOL on at the end of 2019 so I suggest we bump this to Node 10.

I suppose this counts as a breaking change.

Also, I'm not sure if it's worth adding an explicit engines declaration to package.json.

birtles added a commit to birtles/karma-firefox-launcher that referenced this issue Jul 14, 2020
BREAKING CHANGE: Changed minimum required version of node.js from 8 to 10.

Node 8 EOL was 2019-12-31.

Fixes karma-runner#118.
birtles added a commit that referenced this issue Jul 15, 2020
BREAKING CHANGE: Changed minimum required version of node.js from 8 to 10.

Node 8 EOL was 2019-12-31.

Fixes #118.
karmarunnerbot pushed a commit that referenced this issue Oct 20, 2020
# [2.0.0](v1.3.0...v2.0.0) (2020-10-20)

### Bug Fixes

* Bypass WSL check if Firefox is present in WSL environment ([23a5d10](23a5d10)), closes [#107](#107)
* Update is-wsl to v2.2.0 to detect docker under WSL ([#116](#116)) ([c585393](c585393))

### Features

* Make Node 10 minimum required version ([480dafd](480dafd)), closes [#118](#118)

### BREAKING CHANGES

* Changed minimum required version of node.js from 8 to 10.

Node 8 EOL was 2019-12-31.
@karmarunnerbot
Copy link
Member

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants