Merge pull request #2049 from DougBlumeyer/feature-emit-error-on-disc…

…onnect feat(browser): Emit a browser error when a disconnect occurs.
karma-runner · Apr 12, 2016 · 7814de0 · 7814de0
2 parents 2dc4ac8 + 8e15a33
commit 7814de0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/lib/browser.js b/lib/browser.js
@@ -37,6 +37,7 @@ var Browser = function (id, fullName, /* capturedBrowsers */ collection, emitter
     self.state = DISCONNECTED
     self.disconnectsCount++
     log.warn('Disconnected (%d times)' + (reason || ''), self.disconnectsCount)
+    emitter.emit('browser_error', self, 'Disconnected' + reason)
     collection.remove(self)
   }
 

diff --git a/test/unit/browser.spec.js b/test/unit/browser.spec.js
@@ -394,9 +394,13 @@ describe('Browser', () => {
       socket.emit('result', {success: true, suite: [], log: []})
       socket.emit('disconnect', 'socket.io reason')
 
+      var spyBrowserError = sinon.spy()
+      emitter.on('browser_error', spyBrowserError)
+
       timer.wind(10)
       expect(browser.lastResult.disconnected).to.equal(true)
       expect(spy).to.have.been.calledWith(browser)
+      expect(spyBrowserError).to.have.been.called
     })
 
     it('restarting a disconnected browser', () => {