-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Given up on semver? #3105
Comments
There are no changes to the API in 2.x. If you have a specific bug, please provide actual information. |
The changelog says otherwise
On 7 Aug 2018 16:05, johnjbarton <[email protected]> wrote:
There are no changes to the API in 2.x. If you have a specific bug, please provide actual information.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#3105 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AIDP0iyiq0-GvCIa2Aq14_0fJGyA9esBks5uOayigaJpZM4VyDZZ>.
|
@johnjbarton I feel like @alasdairhurst got a point there. E.g. v2.0.3 explicitly lists "BREAKING CHANGES".
|
You are welcome to review changes as they occur and suggest improvements. What breaking changes occurred in 2.0.3? v3 dropped node 4, a breaking change. |
I'm afraid I already clearly stated that in my comment:
This is correct. However, as visible from the link I put into my comment, I was referring to the releases page: https://github.com/karma-runner/karma/releases/tag/v3.0.0 |
v2.0.3 had no breaking change; the docs were wrong due to an old error, and they were corrected. v3.0.0 had breaking changes; the docs omitted these, turns out 'chore' commits are omitted from the change log. The error has also been corrected. Next time please consider sending a PR to fix docs. |
@johnjbarton Any chance to add this breaking change in https://github.com/karma-runner/karma/releases ? Missed that when scanning the changelog through this page. |
Ugh, 2 changelogs? We should delete one. I updated the second one as well, thanks. |
Looking at all the 2.x releases i don't see any attempt to follow semver, with breaking changes and features dotted around in each patch version. Are we expected to just rely on package-lock to stop CI picking up breaking changes unexpectedly now?
The text was updated successfully, but these errors were encountered: