refactor(preprocessor): sort the binary extension list #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort the extension list used to determine whether a file is binary in the alphabetical order.
| @@ -12,17 +12,22 @@ var sha1 = function(data) { | |||
| }; | |||
|
|
|||
| var isBinary = Object.create(null); | |||
| // TODO(aymeric): keep this list alphabetically sorted and wrapped to 80 | |||
There was a problem hiding this comment.
Why TODO?
For me more appropriate something like NOTE.
|
LGTM |
|
What with this PR? |
|
No longer feasible. Also it has a limited interest. |
This was referenced Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort the extension list used to determine whether a file is binary in the
alphabetical order.