fix: exit with error on retry give up #1151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vojtajina take a look at this PR please |
|
@j0tunn 🆗 👍 |
j0tunn
changed the title
When browser not responding karma just logs "ERROR [launcher]: <browser> failed 2 times (timeout). Giving up." and hangs. We should exit with error in such case.
|
@vojtajina Could you please review and merge this pr? |
| @@ -106,7 +110,7 @@ var BaseLauncher = function(id, emitter) { | |||
| this.emit('done'); | |||
|
|
|||
| if (this.error && this.state !== BEING_FORCE_KILLED && this.state !== RESTARTING) { | |||
| emitter.emit('browser_process_failure', this); | |||
There was a problem hiding this comment.
Why don't we get into this place when self.retryLimit equal 0?
There was a problem hiding this comment.
Good question... Seems like because nobody calls self._done. In our case karma-webdriver-launcher just calls self.emit('done') and skips this code. Looks like we need to fix karma-webdriver-launcher.
|
Yep, not a karma issue but karma-webdriver-launcher, so I'm closing PR. |
|
@j0tunn no problems! Thanks! |
|
karma-webdriver-launcher related PR: karma-runner/karma-webdriver-launcher#15 |
This was referenced Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When browser not responding karma just logs
ERROR [launcher]: <browser> failed 2 times (timeout). Giving up.and hangs.We should exit with error in such case.