test(file-list): Use path.posix to fix tests when run on Windows #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with your Pull Request
Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html This message was auto-generated by https://gitcop.com |
Volune
force-pushed
the
fix-tests-on-windows
branch
2 times, most recently
from
c0a8d56
to
f87a651
Compare
Have file-list.js use path.posix instead of path itself, so the tests can expect a '/' separator on any platform. Node 0.10 doesn't provide path.posix and will still fail on Windows. Closes karma-runner#1028
Volune
force-pushed
the
fix-tests-on-windows
branch
from
f87a651
to
6030807
Compare
|
Thanks a lot! |
dignifiedquire
added a commit
that referenced
this pull request
Nov 29, 2015
test(file-list): Use path.posix to fix tests when run on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have file-list.js use path.posix instead of path itself, so the tests can expect a '/' separator on any platform.
Closes #1028