Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runner): Remove null characters from terminal output #1839

Conversation

budde377
Copy link
Member

This slices the buffer rather than modifying it. The buffer slice is returned, with the exit code, as an object:

{
  exitCode: int,
  buffer: Buffer
}

Remove the null characters from the output printed by not replacing
the "tail" with `\x00`. An buffer slice is returned when necessary.

Closes karma-runner#1343
@dignifiedquire
Copy link
Member

What is the exact difference for the user from doing this/what exactly is fixed here?

@budde377
Copy link
Member Author

Basically this fixes the issue: #1343, where a user reported that the \x00 characters printed in the console would appear as symbols. This fix slices the tail off the buffer rather than replacing it with the \x00 bytes.

@dignifiedquire
Copy link
Member

@budde377 thanks, just saw you mentioned it in the commit message -.-

dignifiedquire added a commit that referenced this pull request Jan 28, 2016
…-from-terminal-output

fix(runner): Remove null characters from terminal output
@dignifiedquire dignifiedquire merged commit 0d3bee4 into karma-runner:master Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants