Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(file-list): Stop polluting global environment with core-js #2690

Merged
merged 1 commit into from
May 28, 2017
Merged

fix(file-list): Stop polluting global environment with core-js #2690

merged 1 commit into from
May 28, 2017

Conversation

JakeChampion
Copy link
Contributor

@JakeChampion JakeChampion commented May 6, 2017

When using Karma programatically I came across issues which were due to core-js polluting the environment. It turns out that all Karma needs from core-js (whilst karma supports node 0.x versions) is Map and Set, switching to the file includes for these minimises the amount of core-js being used :-)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@JakeChampion
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@dignifiedquire dignifiedquire merged commit be83116 into karma-runner:master May 28, 2017
@JakeChampion JakeChampion deleted the patch-3 branch June 26, 2017 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants