Fix Travis commit message checks #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only validate comment message when `VALIDATE_COMMIT_MSG` is set, and don't run Travis twice anymore. Fixes #2766
We pass the path relative to the .git directory, which is what `validate-commit-msg` is expecting. A few extra items will also be traced in case anything breaks in the future. Fixes #2753
chrahunt
changed the title
|
Ping @dignifiedquire. Hopefully this will help unblock the existing PRs. |
|
Thank you, this should make things easier !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of problems related to commit message validation:
validate-commit-msgrather than relative to.gitdirectoryWith those fixed, the ✅ is back!