fix(config): Call debug log methods after setting the loglevel based upon config/cli-options #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
requested changes
Oct 25, 2017
lib/config.js
Outdated
| // if no config file path is passed, we define a dummy config module. | ||
| configModule = function () {} | ||
| } | ||
|
|
||
| var config = new Config() | ||
| var config = new Config() |
There was a problem hiding this comment.
this seems unrelated/wrong indentation
There was a problem hiding this comment.
Not quite sure how that happened, I've fixed it via the Github editor.
…upon config/cli-options.
|
@dignifiedquire updated pr in line with your review |
dignifiedquire
approved these changes
Nov 22, 2017
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the debug message about where the configfile was loaded from is always shown, regardless of the user defined loglevel. I've moved those debug messages to be done after the user's defined loglevel has been set which enables the user to choose whether they see this message or not :-)
Alternative fix the problem described in #2658