Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: install semantic-release as a regular dev dependency #3455

Merged
merged 1 commit into from
Apr 7, 2020
Merged

fix: install semantic-release as a regular dev dependency #3455

merged 1 commit into from
Apr 7, 2020

Conversation

devoto13
Copy link
Collaborator

@devoto13 devoto13 commented Apr 7, 2020 •
edited
Loading

Also changed global executable to NPM script as global executable will not be available unless the package is installed globally (with npm i -g).

@devoto13 devoto13 mentioned this pull request Apr 7, 2020
Closed
@karmarunnerbot
Copy link
Member

✅ Build karma 153 completed (commit 884fee797a by @devoto13)

@AppVeyorBot
Copy link

✅ Build karma 2551 completed (commit 884fee797a by @devoto13)

@karmarunnerbot
Copy link
Member

✅ Build karma 152 completed (commit 884fee797a by @devoto13)

@karmarunnerbot
Copy link
Member

✅ Build karma 154 completed (commit 405edbc232 by @devoto13)

@AppVeyorBot
Copy link

✅ Build karma 2552 completed (commit 405edbc232 by @devoto13)

@karmarunnerbot
Copy link
Member

✅ Build karma 153 completed (commit 405edbc232 by @devoto13)

@devoto13
fix: install semantic-release as a regular dev dependency
cb98e3d 
Also changed global executable to NPM script as global executable will not be available unless the package is installed globally (with `npm i -g`).
johnjbarton
johnjbarton approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@karmarunnerbot
Copy link
Member

✅ Build karma 155 completed (commit 6b5aef50c5 by @devoto13)

@AppVeyorBot
Copy link

✅ Build karma 2553 completed (commit 6b5aef50c5 by @devoto13)

@karmarunnerbot
Copy link
Member

✅ Build karma 154 completed (commit 6b5aef50c5 by @devoto13)

@johnjbarton johnjbarton merged commit 1eaf35e into karma-runner:master Apr 7, 2020
@devoto13 devoto13 deleted the semantic-release-deps branch April 7, 2020 16:00
karmarunnerbot pushed a commit that referenced this pull request Apr 9, 2020
@semantic-release-bot
chore(release): 5.0.0 [skip ci]
1b48637 
# [5.0.0](v4.4.1...v5.0.0) (2020-04-09)

### Bug Fixes

* install semantic-release as a regular dev dependency ([#3455](#3455)) ([1eaf35e](1eaf35e))
* **ci:** echo travis env that gates release after_success ([#3446](#3446)) ([b8b2ed8](b8b2ed8))
* **ci:** poll every 10s to avoid rate limit. ([#3388](#3388)) ([91e7e00](91e7e00))
* **middleware/runner:** handle file list rejections ([#3400](#3400)) ([80febfb](80febfb)), closes [#3396](#3396) [#3396](#3396)
* **server:** cleanup import of the removed method ([#3439](#3439)) ([cb1bcbf](cb1bcbf))
* **server:** createPreprocessor was removed ([#3435](#3435)) ([5c334f5](5c334f5))
* **server:** detection new MS Edge Chromium ([#3440](#3440)) ([7166ce2](7166ce2))
* **server:** replace optimist on yargs lib ([#3451](#3451)) ([ec1e69a](ec1e69a)), closes [#2473](#2473)
* **server:** Report original error message ([#3415](#3415)) ([79ee331](79ee331)), closes [#3414](#3414)

### Code Refactoring

* use native Promise instead of Bluebird ([#3436](#3436)) ([33a069f](33a069f)), closes [/github.com//pull/3060#discussion_r284797390](https://github.com//github.com/karma-runner/karma/pull/3060/issues/discussion_r284797390)

### Continuous Integration

* drop node 8, adopt node 12 ([#3430](#3430)) ([a673aa8](a673aa8))

### Features

* **docs:** document `DEFAULT_LISTEN_ADDR` constant ([#3443](#3443)) ([057d527](057d527)), closes [#2479](#2479)
* **karma-server:** added log to the server.js for uncaught exception ([#3399](#3399)) ([adc6a66](adc6a66))
* **preprocessor:** obey Pattern.isBinary when set ([#3422](#3422)) ([708ae13](708ae13)), closes [#3405](#3405)

### BREAKING CHANGES

* Karma plugins which rely on the fact that Karma uses Bluebird promises may break as Bluebird-specific API is no longer available on Promises returned by the Karma core
* **server:** Deprecated createPreprocessor removed, karma-browserify < 7 version doesn't work
* no more testing on node 8.
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Den-dp
Copy link

Den-dp commented Apr 9, 2020

Here is my 2 cents... There is a more elegant way of solving this via npx ad777f0#r38206422

@johnjbarton
Copy link
Contributor

Could you elaborate? I don't know npx.

@devoto13
Copy link
Collaborator Author

devoto13 commented Apr 9, 2020

It is a way to do ad-hoc global package installation, run it in and then uninstall in one command.
I still think that having all these packages in the lock file is cleaner and safer solution. As we always get predictable versions and dependency tree.

@Den-dp
Copy link

Den-dp commented Apr 9, 2020

@johnjbarton https://medium.com/@maybekatz/introducing-npx-an-npm-package-runner-55f7d4bd282b

@devoto13 so yes, that is just one way of doing it. Assuming the fact that semantic-release packages adhere to semver - it should be safe just to specify a major package version in npx call.

Pros 👍

  • More lightweight and easy-to-maintain configuration via one line.

Cons 👎

  • Theoretically some transitive dependency may break one day, so pulling the latest every time is less safe than installing it as a deps.

Just found that semantic-release docs suggests using a mixed approach with installing all deps but running it via npx instead of adding semantic-release script (so npx will use packages from node_modules) https://semantic-release.gitbook.io/semantic-release/usage/installation#local-installation But that's minor

@karronoli karronoli mentioned this pull request Aug 16, 2022
Merged
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
@devoto13 @anthony-redFox
fix: install semantic-release as a regular dev dependency (karma-runn…
3e4e1c8 
…er#3455)

Also changed global executable to NPM script as global executable will not be available unless the package is installed globally (with `npm i -g`).
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
@semantic-release-bot @anthony-redFox
chore(release): 5.0.0 [skip ci]
d4e245c 
# [5.0.0](karma-runner/karma@v4.4.1...v5.0.0) (2020-04-09)

### Bug Fixes

* install semantic-release as a regular dev dependency ([karma-runner#3455](karma-runner#3455)) ([1eaf35e](karma-runner@1eaf35e))
* **ci:** echo travis env that gates release after_success ([karma-runner#3446](karma-runner#3446)) ([b8b2ed8](karma-runner@b8b2ed8))
* **ci:** poll every 10s to avoid rate limit. ([karma-runner#3388](karma-runner#3388)) ([91e7e00](karma-runner@91e7e00))
* **middleware/runner:** handle file list rejections ([karma-runner#3400](karma-runner#3400)) ([80febfb](karma-runner@80febfb)), closes [karma-runner#3396](karma-runner#3396) [karma-runner#3396](karma-runner#3396)
* **server:** cleanup import of the removed method ([karma-runner#3439](karma-runner#3439)) ([cb1bcbf](karma-runner@cb1bcbf))
* **server:** createPreprocessor was removed ([karma-runner#3435](karma-runner#3435)) ([5c334f5](karma-runner@5c334f5))
* **server:** detection new MS Edge Chromium ([karma-runner#3440](karma-runner#3440)) ([7166ce2](karma-runner@7166ce2))
* **server:** replace optimist on yargs lib ([karma-runner#3451](karma-runner#3451)) ([ec1e69a](karma-runner@ec1e69a)), closes [karma-runner#2473](karma-runner#2473)
* **server:** Report original error message ([karma-runner#3415](karma-runner#3415)) ([79ee331](karma-runner@79ee331)), closes [karma-runner#3414](karma-runner#3414)

### Code Refactoring

* use native Promise instead of Bluebird ([karma-runner#3436](karma-runner#3436)) ([33a069f](karma-runner@33a069f)), closes [/github.com/karma-runner/pull/3060#discussion_r284797390](https://github.com//github.com/karma-runner/karma/pull/3060/issues/discussion_r284797390)

### Continuous Integration

* drop node 8, adopt node 12 ([karma-runner#3430](karma-runner#3430)) ([a673aa8](karma-runner@a673aa8))

### Features

* **docs:** document `DEFAULT_LISTEN_ADDR` constant ([karma-runner#3443](karma-runner#3443)) ([057d527](karma-runner@057d527)), closes [karma-runner#2479](karma-runner#2479)
* **karma-server:** added log to the server.js for uncaught exception ([karma-runner#3399](karma-runner#3399)) ([adc6a66](karma-runner@adc6a66))
* **preprocessor:** obey Pattern.isBinary when set ([karma-runner#3422](karma-runner#3422)) ([708ae13](karma-runner@708ae13)), closes [karma-runner#3405](karma-runner#3405)

### BREAKING CHANGES

* Karma plugins which rely on the fact that Karma uses Bluebird promises may break as Bluebird-specific API is no longer available on Promises returned by the Karma core
* **server:** Deprecated createPreprocessor removed, karma-browserify < 7 version doesn't work
* no more testing on node 8.
This was referenced Jan 1, 2024
Open
Open
@Omrisnyk Omrisnyk mentioned this pull request Feb 2, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Feb 11, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Mar 15, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request May 28, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Jun 19, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Jul 2, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnjbarton johnjbarton johnjbarton approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devoto13 @karmarunnerbot @AppVeyorBot @Den-dp @johnjbarton