chore(test): add test for flush resultsBuffer on engine upgrade #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build karma 223 completed (commit a119c05bd4 by @devoto13) |
|
✅ Build karma 224 completed (commit a119c05bd4 by @devoto13) |
|
Actually I see we are blocked by #3486. Could that change have unintended side-effects? |
devoto13
force-pushed
the
test-flush-results
branch
from
65a01d3
to
3dc949d
Compare
|
✅ Build karma 227 completed (commit 37bfb42312 by @devoto13) |
|
✅ Build karma 226 completed (commit 37bfb42312 by @devoto13) |
|
🎉 This PR is included in version 5.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
anthony-redFox
pushed a commit
to anthony-redFox/karma
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test case to catch #3212 regressions. It fails now, but will pass once the other PR is merged and test is rebased.