chore(testing): stop log4js output in unit tests #3634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build karma 2883 completed (commit 026732dbce by @johnjbarton) |
|
✅ Build karma 485 completed (commit 026732dbce by @johnjbarton) |
|
✅ Build karma 486 completed (commit 026732dbce by @johnjbarton) |
devoto13
approved these changes
Jan 26, 2021
test/unit/mocha-globals.js
Outdated
| @@ -17,11 +18,13 @@ beforeEach(() => { | |||
|
|
|||
| // set logger to log INFO, but do not append to console | |||
There was a problem hiding this comment.
nit: I guess this comment is obsolete now? Maybe replace it with the text from the PR description.
johnjbarton
force-pushed
the
no-unit-logs
branch
from
8b29b03
to
8d9fe31
Compare
|
✅ Build karma 2893 completed (commit faf67d722b by @johnjbarton) |
|
✅ Build karma 496 completed (commit faf67d722b by @johnjbarton) |
|
✅ Build karma 495 completed (commit faf67d722b by @johnjbarton) |
devoto13
approved these changes
Jan 27, 2021
|
🎉 This PR is included in version 6.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
anthony-redFox
pushed a commit
to anthony-redFox/karma
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use https://log4js-node.github.io/log4js-node/recording.html to verify logs