-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESM Config File Support #3679
base: master
Are you sure you want to change the base?
ESM Config File Support #3679
Conversation
✅ Build karma 2987 completed (commit 251ec7ab15 by @npetruzzelli) |
✅ Build karma 590 completed (commit 251ec7ab15 by @npetruzzelli) |
✅ Build karma 589 completed (commit 251ec7ab15 by @npetruzzelli) |
@devoto13 - Does Karma currently need to support any versions of node that doesn't support |
Yes, Karma still supports Node 10, but it will be dropped in the next major release as Node 10 has reached the end of life in April. I would suggest to let this PR hang for a bit longer, until we start a branch for the next major release, so we need less cleanup to do. |
Sounds like a good plan to me. |
6fe6df0
to
56cda53
Compare
Might I ask about when, will this go into master? 😂 In case, someone search issue and come here like me, here's my quick workaround using require hook. |
At the very least I would have to merge in the latest Realistically, this isn't going to be the PR that gets merged, for a few reasons:
@devoto13 - is there a milestone / issue tag / some kind of tracker that lists what needs to be done before a pre-release branch for Karma 7.x is made available for contributions? I might have some time this month/next month to make a contribution |
@npetruzzelli CI is fixed now. I think it's mainly some maintainers' time to implement/review/test/land breaking changes, so we don't end up being stuck in pre-release mode for a long time and probably @jginsburgn's approval to start working on the next major 😄 There is #3503 tracking breaking changes I would like to make (not necessarily all of them) + some of the open PRs. It is pretty hot time at work now, so I'm not sure when I'll have some time to look into it. Note that it's possible to install karma from GitHub as well. So if you rebase this PR, people can install it using similar approach as #3726 (comment). |
Got it, if I have a chance, I will at least try to update this branch. Thank you. In the mean time, @loynoir may be interested in: #3677 (comment) It requires 1 extra file, but you won't need any additional command line arguments when running node. Use what works best for you. |
#3677