Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install ingress-nginx by dev-env.sh script #17

Closed
wants to merge 1 commit into from

Conversation

laihezhao
Copy link

I install the ingress-controller in the kubernetes, the context of the script is from dev-env.sh

install.sh

kubectl create ns ingress-nginx

cat << EOF | helm template ingress-nginx ./src/charts/ingress-nginx --namespace=ingress-nginx --values - | kubectl apply -n ingress-nginx --validate=false -f -
controller:
  image:
    repository: registry-dev.indc.vnet.com
    image: system_containers/k8s-staging-ingress-nginx
    tag: v1.1.1
    digest:
  config:
    worker-processes: "1"
  podLabels:
    deploy-date: "$(date +%s)"
  updateStrategy:
    type: RollingUpdate
    rollingUpdate:
      maxUnavailable: 1
  hostPort:
    enabled: true
  terminationGracePeriodSeconds: 0
  service:
    type: NodePort
  admissionWebhooks:
    patch:
      image:
        registry: registry-dev.indc.vnet.com
        image: system_containers/kube-webhook-certgen
        tag: v1.1.1
        digest: sha256:78351fc9d9b5f835e0809921c029208faeb7fbb6dc2d3b0d1db0a6584195cfed
EOF

I got the error

NAME                                        READY   STATUS             RESTARTS   AGE   IP               NODE         NOMINATED NODE   READINESS GATES
ingress-nginx-admission-create-tmtk7        0/1     Completed          0          11m   172.31.175.202   k8s-node-6   <none>           <none>
ingress-nginx-admission-patch-s9rfh         0/1     Completed          0          11m   172.31.175.222   k8s-node-6   <none>           <none>
ingress-nginx-controller-75b989ddd7-2j949   0/1     ImagePullBackOff   0          11m   172.31.55.171    k8s-node-4   <none>           <none>

I check the log of ingress-nginx-controller-75b989ddd7-2j949 pod, the result is

  containerStatuses:
  - image: registry-dev.indc.vnet.com:v1.1.1
    imageID: ""
    lastState: {}
    name: controller
    ready: false
    restartCount: 0
    started: false
    state:
      waiting:
        message: Back-off pulling image "registry-dev.indc.vnet.com:v1.1.1"
        reason: ImagePullBackOff

so I think the dev-env.sh has problem

What this PR does / why we need it:

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@karmada-bot
Copy link
Collaborator

Welcome @laihezhao! It looks like this is your first PR to karmada-io/multi-cluster-ingress-nginx 🎉

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 28, 2024
@XiShanYongYe-Chang
Copy link
Member

Hi @laihezhao Thanks a lot~
I will review it ASAP.
/assign

@XiShanYongYe-Chang
Copy link
Member

Hi @laihezhao The content of the current main branch is different from what you showed. The current content is:

image:
repository: ${REGISTRY}/controller
tag: ${TAG}

The default value of REGISTRY is set in the Makefile:

REGISTRY ?= gcr.io/k8s-staging-ingress-nginx

Have you modified the value in the environment variable?

@laihezhao
Copy link
Author

@XiShanYongYe-Chang Thank you 。I see. I misunderstood.

@laihezhao laihezhao marked this pull request as draft March 1, 2024 09:09
@karmada-bot karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2024
@laihezhao laihezhao closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants