RavenDB-22292 limit time series retention tx to 16MB

karmeli87 · Apr 18, 2024 · d15502e · d15502e
1 parent 81b1d82
commit d15502e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/src/Raven.Server/Documents/TimeSeries/TimeSeriesRollups.cs b/src/Raven.Server/Documents/TimeSeries/TimeSeriesRollups.cs
@@ -238,6 +238,7 @@ public static void SplitKey(Slice key, out string docId, out string name)
         internal class TimeSeriesRetentionCommand : TransactionOperationsMerger.MergedTransactionCommand
         {
             public const int BatchSize = 1024;
+            private static readonly Size MaxTransactionSize = new(16, SizeUnit.Megabytes);
 
             private readonly List<Slice> _keys;
             private readonly string _collection;
@@ -274,6 +275,9 @@ protected override long ExecuteCmd(DocumentsOperationContext context)
 
                     if (logger.IsInfoEnabled)
                         logger.Info($"{request} was executed (successfully: {done})");
+
+                    if (context.Transaction.InnerTransaction.LowLevelTransaction.TransactionSize > MaxTransactionSize)
+                        break;
                 }
 
                 return retained;

diff --git a/src/Raven.Server/Documents/TimeSeries/TimeSeriesStorage.cs b/src/Raven.Server/Documents/TimeSeries/TimeSeriesStorage.cs
@@ -527,13 +527,13 @@ public static void RemoveTimeSeriesNameFromMetadata(DocumentsOperationContext ct
         {
             var storage = ctx.DocumentDatabase.DocumentsStorage;
 
-            var doc = storage.Get(ctx, docId);
-            if (doc == null)
-                return;
-
             var tss = storage.TimeSeriesStorage;
             if (tss.Stats.GetStats(ctx, docId, tsName).Count > 0)
                 return;
+
+            var doc = storage.Get(ctx, docId);
+            if (doc == null)
+                return;
 
             var data = doc.Data;
             var flags = doc.Flags.Strip(DocumentFlags.FromClusterTransaction | DocumentFlags.Resolved);

diff --git a/src/Voron/Impl/LowLevelTransaction.cs b/src/Voron/Impl/LowLevelTransaction.cs
@@ -95,6 +95,8 @@ public void Reset()
 
         public event Action<LowLevelTransaction> LastChanceToReadFromWriteTransactionBeforeCommit;
 
+        public Size TransactionSize => new Size(NumberOfModifiedPages * Constants.Storage.PageSize, SizeUnit.Bytes) + AdditionalMemoryUsageSize;
+
         public Size AdditionalMemoryUsageSize
         {
             get