Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in Bootstrap 4 #140

Closed
faravaghi opened this issue Dec 17, 2019 · 5 comments
Closed

Error in Bootstrap 4 #140

faravaghi opened this issue Dec 17, 2019 · 5 comments
Labels
wontfix

Comments

@faravaghi
Copy link

faravaghi commented Dec 17, 2019 •
edited by kartik-v
Loading

yii2-builder/src/FormGrid.php

Line 12 in 7983d4a

use yii\bootstrap\Widget;

hi, when bootstrap 3.x remove show error in this line.
I think change this code with:

use kartik\base\Widget;
@bravo2
Copy link
Contributor

bravo2 commented Dec 20, 2019

Replacing use yii\bootstrap\Widget; with use kartik\base\Widget; fixes the issue with bootstrap4.
@kartik-v If I submit this change as a PR, would you make a release with the change?

@kartik-v
Copy link
Owner

kartik-v commented Dec 21, 2019 •
edited
Loading

Ok please submit the PR... Thanks

bravo2 pushed a commit to bravo2/yii2-builder that referenced this issue Dec 21, 2019
@bijoys
Fix for kartik-v#140
955f968 
Added support for bootstrap4 by replacing yii\bootstrap\Widget with kartik\base\Widget
@bravo2 bravo2 mentioned this issue Dec 21, 2019
Merged
2 tasks
@stale
Copy link

stale bot commented Feb 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 19, 2020
kartik-v added a commit that referenced this issue Feb 19, 2020
@kartik-v
Merge pull request #141 from bravo2/140-fix
74843d7 
Fix for #140
@kartik-v
Copy link
Owner

Fixed via #141

@bijoys
Copy link

bijoys commented Nov 28, 2020

@kartik-v Can you please create a release with the latest master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kartik-v @faravaghi @bravo2 @bijoys