Geonode client #15

myarjunar · 2017-03-30T16:09:02Z

Description

Add general functionality to the manager dialog. ( #2 #9 #11 )
Add geonode browser panel ( still cannot populate layers/maps to the browser ). ( #3 )
Add layer from geonode manager dialog to the map.

Browser panel:

Create new geonode connection:

Save geonode connection:

Load geonode connection from exported connection:

Delete geonode connection:

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

Commit messages are descriptive and explain the rationale for changes
Commits which fix bugs include fixes #11111 in the commit message next to the description
Commits which add new features are tagged with [FEATURE] in the commit message
Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
I have read the QGIS Coding Standards and this PR complies with them
This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
New unit tests have been added for core changes
I have run the scripts/prepare-commit.sh script before each commit

timlinux · 2017-03-30T18:20:07Z

That is looking really great @myarjunar and @ismailsunni !

Gustry · 2017-04-11T06:51:36Z

You should update master at the same time. The PR is hard to read now.
Maybe github will still display old commits from QGIS. A rebase may be needed.

Gustry · 2017-04-11T06:54:14Z

src/app/geonode/qgsgeonodesourceselect.cpp

+
+  populateConnectionList();
+
+  connect( buttonBox, SIGNAL( rejected() ), this, SLOT( reject() ) );


This is old style connect. We need to move to the new style.

Gustry · 2017-04-11T06:54:39Z

src/app/geonode/qgsgeonodesourceselect.cpp

+  treeView->setItemDelegate( mItemDelegate );
+
+  mModel = new QStandardItemModel();
+  mModel->setHorizontalHeaderItem( MODEL_IDX_TITLE, new QStandardItem( QStringLiteral( "Title" ) ) );


Missing translation ?

ismailsunni · 2017-04-11T07:05:10Z

Oops, the commit from Tim and I for fixing the conflict got merged in one of the commit.

Gustry · 2017-04-11T08:37:37Z

Is-it not fine ?

ismailsunni · 2017-04-11T10:53:59Z

@Gustry it's fine. Nothing is lose, beside Tim's name in the list of this PR commiters.

Gustry

Awesome work. I'm not a C reviewer, I just a did quick look. Well done.
Is-there any SIP bindings?

Gustry · 2017-04-19T08:36:48Z

src/app/geonode/qgsgeonodenewconnection.cpp

+  // Adjust height
+  int w = width();
+  adjustSize();
+  resize( w, height() );


Can't we use width() here ? Or do you need w ?

somehow if we use width() directly, the size is not as what I'm expecting.

Gustry · 2017-04-19T08:37:08Z

src/app/geonode/qgsgeonodenewconnection.cpp

+  buttonBox->button( QDialogButtonBox::Ok )->setDisabled( true );
+  connect( txtName, SIGNAL( textChanged( QString ) ), this, SLOT( okButtonBehavior( QString ) ) );
+  connect( txtUrl, SIGNAL( textChanged( QString ) ), this, SLOT( okButtonBehavior( QString ) ) );
+  connect( btnConnect, SIGNAL( clicked() ), this, SLOT( testConnection() ) );


You need to remove these old style connect

Gustry · 2017-04-19T08:40:25Z

src/providers/ows/qgsowsdataitems.cpp

+  {
+    refresh();
+  }
+}*/


Still useful ?

yes, I leave it there as a reminder 😅

Gustry · 2017-06-15T07:05:41Z

src/app/qgisapp.cpp

@@ -4464,6 +4464,8 @@ void QgisApp::addGeonodeLayer()
  }
  connect( geonodes, SIGNAL( addRasterLayer( QString const &, QString const &, QString const & ) ),
           this, SLOT( addRasterLayer( QString const &, QString const &, QString const & ) ) );
+  connect( geonodes, SIGNAL( addWfsLayer( QString, QString, QString ) ),


This an old style connect. You need to use the new-style, QGIS doesn't allow new "old" style anymore.

Ah shame, I didn't check that one. I was focusing to fix the new slot. Ok, I will fix it. Thanks @Gustry

Gustry · 2017-08-16T14:57:47Z

Can we close this PR? as it's not on this branch anyway and there is the PR on the QGIS repo now

These references are to objects belonging to another thread, which can cause crashes if the object on the main thread is deleted while the handler is still active Refs a asan report: ==677416==ERROR: AddressSanitizer: heap-use-after-free on address 0x6070029bc278 at pc 0x7f95719ccc45 bp 0x7f94bdd7a310 sp 0x7f94bdd7a300 READ of size 4 at 0x6070029bc278 thread T36 (Thread (pooled)) #0 0x7f95719ccc44 in QgsLine3DSymbol::extrusionHeight() const /home/nyall/dev/qgis-asan/src/3d/symbols/qgsline3dsymbol.h:78 kartoza#1 0x7f95674a7c01 in QgsBufferedLine3DSymbolHandler::processFeature(QgsFeature&, Qgs3DRenderContext const&) /home/nyall/dev/qgis-asan/src/3d/symbols/qgsline3dsymbol_p.cpp:126 kartoza#2 0x7f9567457045 in operator() /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.cpp:97 kartoza#3 0x7f95674597fd in runFunctor /usr/include/qt5/QtConcurrent/qtconcurrentstoredfunctioncall.h:70 kartoza#4 0x7f956744acf7 in QtConcurrent::RunFunctionTask<void>::run() (/home/nyall/dev/build-QGIS-asan/output/lib/libqgis_3d.so.3.15.0+0x2adcf7) kartoza#5 0x7f956a275d59 (/usr/lib64/libQt5Core.so.5+0xc9d59) kartoza#6 0x7f956a27268f (/usr/lib64/libQt5Core.so.5+0xc668f) kartoza#7 0x7f956a193431 in start_thread (/usr/lib64/libpthread.so.0+0x9431) kartoza#8 0x7f955ad59912 in __GI___clone (/usr/lib64/libc.so.6+0x101912) 0x6070029bc278 is located 56 bytes inside of 72-byte region [0x6070029bc240,0x6070029bc288) freed by thread T0 here: #0 0x7f9572b86b87 in operator delete(void*) (/usr/lib64/libasan.so.6+0xb2b87) kartoza#1 0x7f956749c00b in QgsLine3DSymbol::~QgsLine3DSymbol() /home/nyall/dev/qgis-asan/src/3d/symbols/qgsline3dsymbol.cpp:30 kartoza#2 0x7f95719664ca in std::default_delete<QgsAbstract3DSymbol>::operator()(QgsAbstract3DSymbol*) const /usr/include/c++/10/bits/unique_ptr.h:85 kartoza#3 0x7f95674428ce in std::unique_ptr<QgsAbstract3DSymbol, std::default_delete<QgsAbstract3DSymbol> >::~unique_ptr() /usr/include/c++/10/bits/unique_ptr.h:361 kartoza#4 0x7f9567459eb6 in QgsVectorLayerChunkLoaderFactory::~QgsVectorLayerChunkLoaderFactory() /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.h:53 kartoza#5 0x7f9567459edd in QgsVectorLayerChunkLoaderFactory::~QgsVectorLayerChunkLoaderFactory() /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.h:53 kartoza#6 0x7f956746e4db in QgsChunkedEntity::~QgsChunkedEntity() /home/nyall/dev/qgis-asan/src/3d/chunks/qgschunkedentity_p.cpp:122 kartoza#7 0x7f9567459358 in QgsVectorLayerChunkedEntity::~QgsVectorLayerChunkedEntity() /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.cpp:164 kartoza#8 0x7f9567459373 in QgsVectorLayerChunkedEntity::~QgsVectorLayerChunkedEntity() /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.cpp:168 kartoza#9 0x7f956a42e960 in QObject::event(QEvent*) (/usr/lib64/libQt5Core.so.5+0x282960) kartoza#10 0x7f956ada2062 in QApplicationPrivate::notify_helper(QObject*, QEvent*) (/usr/lib64/libQt5Widgets.so.5+0x172062) previously allocated by thread T0 here: #0 0x7f9572b86067 in operator new(unsigned long) (/usr/lib64/libasan.so.6+0xb2067) kartoza#1 0x7f95674a3018 in qgis::_Unique_if<QgsLine3DSymbol>::_Single_object qgis::make_unique<QgsLine3DSymbol>() /home/nyall/dev/qgis-asan/src/core/qgis.h:425 kartoza#2 0x7f956749c0b9 in QgsLine3DSymbol::clone() const /home/nyall/dev/qgis-asan/src/3d/symbols/qgsline3dsymbol.cpp:34 kartoza#3 0x7f9567458b5f in QgsVectorLayerChunkLoaderFactory::QgsVectorLayerChunkLoaderFactory(Qgs3DMapSettings const&, QgsVectorLayer*, QgsAbstract3DSymbol*, int) /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.cpp:141 kartoza#4 0x7f9567458d88 in QgsVectorLayerChunkedEntity::QgsVectorLayerChunkedEntity(QgsVectorLayer*, double, double, QgsVectorLayer3DTilingSettings const&, QgsAbstract3DSymbol*, Qgs3DMapSettings const&) /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayerchunkloader_p.cpp:159 kartoza#5 0x7f956745558f in QgsVectorLayer3DRenderer::createEntity(Qgs3DMapSettings const&) const /home/nyall/dev/qgis-asan/src/3d/qgsvectorlayer3drenderer.cpp:76 kartoza#6 0x7f95673a71c0 in Qgs3DMapScene::addLayerEntity(QgsMapLayer*) /home/nyall/dev/qgis-asan/src/3d/qgs3dmapscene.cpp:693 kartoza#7 0x7f95673a5523 in Qgs3DMapScene::onLayerRenderer3DChanged() /home/nyall/dev/qgis-asan/src/3d/qgs3dmapscene.cpp:598 kartoza#8 0x7f95673c6c33 in QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (Qgs3DMapScene::*)()>::call(void (Qgs3DMapScene::*)(), Qgs3DMapScene*, void**) (/home/nyall/dev/build-QGIS-asan/output/lib/libqgis_3d.so.3.15.0+0x229c33) kartoza#9 0x7f95673c5468 in void QtPrivate::FunctionPointer<void (Qgs3DMapScene::*)()>::call<QtPrivate::List<>, void>(void (Qgs3DMapScene::*)(), Qgs3DMapScene*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:185 kartoza#10 0x7f95673c1748 in QtPrivate::QSlotObject<void (Qgs3DMapScene::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) /usr/include/qt5/QtCore/qobjectdefs_impl.h:418 kartoza#11 0x7f956a435f75 (/usr/lib64/libQt5Core.so.5+0x289f75) kartoza#12 0x7f956252106c in QgsMapLayer::renderer3DChanged() src/core/qgis_core_autogen/EWIEGA46WW/moc_qgsmaplayer.cpp:702 kartoza#13 0x7f9563917a12 in QgsMapLayer::setRenderer3D(QgsAbstract3DRenderer*) /home/nyall/dev/qgis-asan/src/core/qgsmaplayer.cpp:1813 kartoza#14 0x7f95719aaf52 in QgsApp3DSymbolWidgetWithPreview::updatePreview(QgsAbstract3DSymbol*) /home/nyall/dev/qgis-asan/src/app/3d/qgsapp3dsymbolwidget.cpp:243 kartoza#15 0x7f95719a97af in operator() /home/nyall/dev/qgis-asan/src/app/3d/qgsapp3dsymbolwidget.cpp:175 kartoza#16 0x7f95719ac2dd in call /usr/include/qt5/QtCore/qobjectdefs_impl.h:146 kartoza#17 0x7f95719ac24f in call<QtPrivate::List<>, void> /usr/include/qt5/QtCore/qobjectdefs_impl.h:256 kartoza#18 0x7f95719ac21e in impl /usr/include/qt5/QtCore/qobjectdefs_impl.h:443 kartoza#19 0x7f956a435f75 (/usr/lib64/libQt5Core.so.5+0x289f75) kartoza#20 0x7f95708d15ec in QgsApp3DSymbolWidget::widgetChanged() src/app/qgis_app_autogen/6LADBHSVD5/moc_qgsapp3dsymbolwidget.cpp:144 kartoza#21 0x7f95719ae1dd in QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (QgsApp3DSymbolWidget::*)()>::call(void (QgsApp3DSymbolWidget::*)(), QgsApp3DSymbolWidget*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:152 kartoza#22 0x7f95719add9c in void QtPrivate::FunctionPointer<void (QgsApp3DSymbolWidget::*)()>::call<QtPrivate::List<>, void>(void (QgsApp3DSymbolWidget::*)(), QgsApp3DSymbolWidget*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:185 kartoza#23 0x7f95719adbfa in QtPrivate::QSlotObject<void (QgsApp3DSymbolWidget::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) /usr/include/qt5/QtCore/qobjectdefs_impl.h:418 kartoza#24 0x7f956a435f75 (/usr/lib64/libQt5Core.so.5+0x289f75) kartoza#25 0x7f956c91c63e in Qgs3DSymbolWidget::changed() src/gui/qgis_gui_autogen/EWIEGA46WW/moc_qgs3dsymbolwidget.cpp:131 kartoza#26 0x7f95719ce2ad in QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (Qgs3DSymbolWidget::*)()>::call(void (Qgs3DSymbolWidget::*)(), Qgs3DSymbolWidget*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:152 kartoza#27 0x7f95719ce014 in void QtPrivate::FunctionPointer<void (Qgs3DSymbolWidget::*)()>::call<QtPrivate::List<>, void>(void (Qgs3DSymbolWidget::*)(), Qgs3DSymbolWidget*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:185 qgis#28 0x7f95719cdbfc in QtPrivate::QSlotObject<void (Qgs3DSymbolWidget::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) /usr/include/qt5/QtCore/qobjectdefs_impl.h:418 qgis#29 0x7f956a435f75 (/usr/lib64/libQt5Core.so.5+0x289f75)

cchristelis added the in progress label Mar 30, 2017

ismailsunni force-pushed the geonode-client branch 3 times, most recently from f14ad67 to c965917 Compare April 6, 2017 09:23

Gustry reviewed Apr 11, 2017

View reviewed changes

ismailsunni force-pushed the geonode-client branch from c404843 to 16f5834 Compare April 11, 2017 07:01

ismailsunni force-pushed the geonode-client branch from 0c187e4 to 3153564 Compare April 12, 2017 00:48

Gustry reviewed Apr 19, 2017

View reviewed changes

ismailsunni force-pushed the geonode-client branch 2 times, most recently from 16a17c9 to 24a14c3 Compare April 20, 2017 03:54

myarjunar force-pushed the geonode-client branch 3 times, most recently from 6862253 to fccbb48 Compare April 25, 2017 08:52

myarjunar force-pushed the geonode-client branch from fccbb48 to f90e50d Compare May 18, 2017 02:29

myarjunar force-pushed the geonode-client branch from f90e50d to 80ac38d Compare June 8, 2017 04:19

ismailsunni force-pushed the geonode-client branch from 80ac38d to 63c4141 Compare June 12, 2017 02:47

myarjunar force-pushed the geonode-client branch from 63c4141 to 4ac193c Compare June 13, 2017 05:50

ismailsunni force-pushed the geonode-client branch from 3fdb136 to 0eeb701 Compare June 15, 2017 00:59

myarjunar force-pushed the geonode-client branch from acff4b1 to 413cb80 Compare June 15, 2017 07:04

Gustry reviewed Jun 15, 2017

View reviewed changes

ismailsunni force-pushed the geonode-client branch 2 times, most recently from 04d81f1 to bef51b8 Compare June 16, 2017 23:00

myarjunar force-pushed the geonode-client branch 2 times, most recently from 8f8cc41 to d962fbf Compare June 19, 2017 06:22

myarjunar and others added 25 commits August 6, 2017 19:14

fix compiling warning

5604fd0

Use struct instead QVariantMap.

493eeab

tidy up code

f474a2f

Tidy up code, use QgsStringMap instead QVariantMap.

92d3d5f

Add spellok for catalogue.

a607174

update sip

ca6992d

Use naming convention for QgsGeoCmsConnection and use QUuid.

3941c70

update sip

e722157

Async by using GeoNodeRequest class.

74ff52c

Move geonode to src/gui.

bc522ef

Use stack not heap.

1c1bbe7

Remove unused includes.

e4e6d2e

Use signal to handle request.

4f78b8e

Use QStringLiteral.

d478ca1

Switch to use Q_FOREACH.

ae5e7d4

Use Q_FOREACH and addressing PR's review.

efc1e66

Set private for data members.

49eb791

update sip

9bbb22e

Update sip.

8c6ca95

Update sip.

8790707

Fix sip problem to make it buildable again.

5951d0e

Remove geocms

5055f34

Tidy up code.

edcb87b

Use QgsSetting Scope::Provider.

acb71a5

Fix missing zip.h

f969799

ismailsunni force-pushed the geonode-client branch from 1f5c0ee to f969799 Compare August 6, 2017 17:40

Gustry closed this Aug 16, 2017

Gustry removed the in progress label Aug 16, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Geonode client #15

Geonode client #15

myarjunar commented Mar 30, 2017 •

edited

Loading

timlinux commented Mar 30, 2017

Gustry commented Apr 11, 2017

Gustry Apr 11, 2017

Gustry Apr 11, 2017

ismailsunni commented Apr 11, 2017

Gustry commented Apr 11, 2017

ismailsunni commented Apr 11, 2017

Gustry left a comment

Gustry Apr 19, 2017

myarjunar Apr 20, 2017

Gustry Apr 19, 2017

Gustry Apr 19, 2017

myarjunar Apr 20, 2017

Gustry Jun 15, 2017

ismailsunni Jun 15, 2017

Gustry commented Aug 16, 2017


		populateConnectionList();

		connect( buttonBox, SIGNAL( rejected() ), this, SLOT( reject() ) );

Geonode client #15

Geonode client #15

Conversation

myarjunar commented Mar 30, 2017 • edited Loading

Description

Checklist

timlinux commented Mar 30, 2017

Gustry commented Apr 11, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ismailsunni commented Apr 11, 2017

Gustry commented Apr 11, 2017

ismailsunni commented Apr 11, 2017

Gustry left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Gustry commented Aug 16, 2017

myarjunar commented Mar 30, 2017 •

edited

Loading