Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skipped tests. #248

Merged
merged 5 commits into from
Jun 8, 2017
Merged

Conversation

lucernae
Copy link
Collaborator

@lucernae lucernae commented Jun 6, 2017

Related with: #172

@codecov
Copy link

codecov bot commented Jun 6, 2017

Codecov Report

Merging #248 into master-qgis_server will increase coverage by 0.04%.
The diff coverage is 73.07%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           master-qgis_server     #248      +/-   ##
======================================================
+ Coverage               45.74%   45.79%   +0.04%     
======================================================
  Files                     254      254              
  Lines                   18405    18455      +50     
  Branches                 2420     2434      +14     
======================================================
+ Hits                     8420     8452      +32     
- Misses                   9503     9519      +16     
- Partials                  482      484       +2
Impacted Files Coverage Δ
geonode/geoserver/tests.py 97.6% <ø> (-0.02%) ⬇️
geonode/tests/integration.py 0% <0%> (ø) ⬆️
geonode/security/tests.py 98.9% <100%> (+0.01%) ⬆️
geonode/layers/utils.py 48.89% <100%> (+0.88%) ⬆️
geonode/qgis_server/signals.py 92.9% <89.47%> (-1.21%) ⬇️
geonode/qgis_server/models.py 93.87% <89.65%> (+6.37%) ⬆️
geonode/layers/tests.py 97.36% <89.74%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ccf9d8...e5ae9e2. Read the comment docs.

@lucernae lucernae force-pushed the fix_tests branch 2 times, most recently from adf8514 to 7590405 Compare June 7, 2017 18:25
@Gustry
Copy link
Collaborator

Gustry commented Jun 8, 2017

Nice, thanks !

@lucernae lucernae merged commit 5ddea52 into kartoza:master-qgis_server Jun 8, 2017
@lucernae lucernae deleted the fix_tests branch June 8, 2017 15:27
lucernae added a commit to lucernae/geonode that referenced this pull request Jun 24, 2017
From the works in PR: kartoza#248

* Unskip geoserver only tests.
* Add decorators for specific OGC backend test.
* Fix test for test_get_files. Geoserver and QGIS Server
   have different supports
* Fix security tests. Only relevant for geoserver.
* Fix cascading delete. Add QGIS Server version of the
   test.
* Fix GeoNodeMapTest in integration test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants