Code improvements for Different CRS #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lucernae
commented
Jul 4, 2017
•
lucernae
commented
- Skip bbox check for thumbnail creation. fix Thumbnails not showing for some datasets #287
- Convert bbox to EPSG:4326 for displaying layers. fix Layer map view does not zoom to layer correctly #289
- Try to retrieve layer projection and save Layer CRS. fix Thumbnails not showing for some datasets #287
- Standardize thumbnail generation to use EPSG:4326. fix Thumbnails not showing for some datasets #287
BBOX will be validated by qgis_server helpers.
lucernae
force-pushed
the
code_improvements
branch
from
e4768c0
to
f6b19a5
Compare
- Convert bbox to EPSG:4326 for displaying layers - Try to retrieve layer projection and save Layer CRS - Standardize thumbnail generation to use EPSG:4326
lucernae
force-pushed
the
code_improvements
branch
from
f6b19a5
to
1df6b2e
Compare
Codecov Report
@@ Coverage Diff @@
## master-qgis_server #290 +/- ##
======================================================
+ Coverage 45.72% 45.79% +0.06%
======================================================
Files 261 261
Lines 19009 19044 +35
Branches 2498 2500 +2
======================================================
+ Hits 8692 8721 +29
- Misses 9824 9827 +3
- Partials 493 496 +3
Continue to review full report at Codecov.
|
|
Also made some improvements for #284 . Cover cases when FileField wrongly assumes that QML style doesn't exists |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.