Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify basemaps #545

Open
wants to merge 1 commit into
base: 2.8.x-qgis_server
Choose a base branch
from
Open

modify basemaps #545

wants to merge 1 commit into from

Conversation

boney-bun
Copy link

  • remove OpenMapSurfer and hardcoded basemaps
  • add terrain basemap

fix kartoza/geosafe#531

@boney-bun
modify basemaps
8f802f6 
remove opensurfermap and hardcoded basemap, add terrain

fix kartoza/geosafe#531
@boney-bun boney-bun requested a review from lucernae March 26, 2019 17:22
@ghost ghost assigned boney-bun Mar 26, 2019
@ghost ghost added the in progress label Mar 26, 2019
@boney-bun
Copy link
Author

the PR in action:

  • map
    geosafe#531-map

  • layer
    geosafe#531-layer

Note:

  • This PR hasn't tested to the following use case: choose a layer, then Add to Map (bug add layer to existing map doesn't work #544)

  • the base map will likely show up twice for a created map using this PR:
    Screen Shot 2019-03-27 at 12 35 53 AM

  • however, it is there to tackle old existing maps. for example:
    Screen Shot 2019-03-27 at 12 34 39 AM

@boney-bun boney-bun mentioned this pull request Mar 26, 2019
Closed
@lucernae
Copy link
Collaborator

We need to fix travis error first on the base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucernae lucernae Awaiting requested review from lucernae

@NyakudyaA NyakudyaA Awaiting requested review from NyakudyaA

Assignees

@boney-bun boney-bun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boney-bun @lucernae @gubuntu