O(log n) find, DrawHandle::text_effects, tab entry #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Advantage: calling text_with_effects with only a single effect still uses the faster TextDisplay::glyphs method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WidgetChildren::findandfind_mutmethods now use binary search to achieveO(log n)performance over large numbers of children. This is only really relevant on large lists of children and still probably not the most significant cost, but is another step towards #91.Other changes depend on these changes: kas-gui/kas-text#34
EditBoxnow enters\ton the Tab key to allow testing the new tab support. (Should be configurable later, or depend on the use case?)Added
DrawHandle::text_effectsand revisedDrawTextmethods. We can now forward effects like strikethrough from parsed text. We keepDrawHandle::text_accel(since behaviour depends on an extra state parameter), but move the effect-list creation up toAccelString.