Expand AdaptConfigCx, AdaptEventCx #423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AdaptEventCx
now includes input data. Motivation: reduce the parameter count to various closures. Caveats:AdaptEventCx
must be templated over the input data type. Since users often don't need to explicitly type closure parameters this seems acceptable (at least, more so than it would be forEventCx
).EventCx
, hence (in large part) whyEventCx
does not embed input data.AdaptConfigCx
cannot do the same since it is used byon_configure
which does not have access to input data.Edit: the above provide sufficient motivation not to do this. Instead, data is passed separately with a few exceptions (namely
Adapt::on_message
which is frequently used, (so far) never wants input data, and can be replaced by the lower-levelAdapt::on_messages
method where data is needed).These types are now used by
AdaptWidget
,Grid
andList
.Add fns
map_message
andon_message
toGrid
andList
.Rename
OnUpdate
→AdaptEvents
.