Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: RPC Auth #2090

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

WIP: RPC Auth #2090

wants to merge 4 commits into from

Conversation

cdnsteve
Copy link

@cdnsteve cdnsteve commented Jun 17, 2022

Do not merge, this is a work in progress.

What does this PR do?

An early sneak peak, existing tests passing but lots more to go.

To Do:

  • Create cert and key file and ensure it works, test flags for rpckey rpccert
  • Validate miner is able to connect using TLS
  • Add TLS to rpcClient (this is currently just for server)
  • Make list of other commands to confirm TLS is active, kaspa utils?
  • Refactor some of this sample code and cleanup
  • Create new tests

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #2090 (3f52480) into dev (c5aade7) will decrease coverage by 0.00%.
The diff coverage is 57.69%.

❗ Current head 3f52480 differs from pull request most recent head b9be56a. Consider uploading reports for the commit b9be56a to get more accurate results

@@            Coverage Diff             @@
##              dev    #2090      +/-   ##
==========================================
- Coverage   59.24%   59.23%   -0.01%     
==========================================
  Files         678      678              
  Lines       32767    32781      +14     
==========================================
+ Hits        19413    19419       +6     
- Misses      10554    10560       +6     
- Partials     2800     2802       +2     
Impacted Files Coverage Δ
...etwork/netadapter/server/grpcserver/grpc_server.go 70.58% <47.61%> (-9.97%) ⬇️
infrastructure/config/config.go 12.79% <100.00%> (+0.33%) ⬆️
infrastructure/network/netadapter/netadapter.go 75.58% <100.00%> (ø)
.../network/netadapter/server/grpcserver/p2pserver.go 69.69% <100.00%> (ø)
.../network/netadapter/server/grpcserver/rpcserver.go 100.00% <100.00%> (ø)
.../protocol/flows/v5/blockrelay/handle_relay_invs.go 53.84% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5aade7...b9be56a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant