Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Form / Select Field #451

Closed
2 tasks done
Tracked by #370
resir014 opened this issue Sep 10, 2021 · 3 comments · Fixed by #555 or #563
Closed
2 tasks done
Tracked by #370

[NEW] Form / Select Field #451

resir014 opened this issue Sep 10, 2021 · 3 comments · Fixed by #555 or #563
Assignees
@resir014 @zanuarmirza @DioSyahrizal
Labels
enhancement New feature or request

Comments

@resir014
Copy link
Contributor

resir014 commented Sep 10, 2021 •
edited by DioSyahrizal
Loading

Component References

Figma Link

https://www.figma.com/file/R7ymwKrEI3LF6ssrZe5opG/Desktop-UI-Kit?node-id=10283%3A26667

Page: Form - Select Field

Additional Info

Wrapper for Downshift which adds a Select input with our design guidelines.

Tasks

  • Select
  • Combobox
@resir014 resir014 added the enhancement New feature or request label Sep 10, 2021
@DioSyahrizal DioSyahrizal mentioned this issue Oct 11, 2021
Merged
@resir014 resir014 mentioned this issue Oct 12, 2021
Open
36 tasks
@treecore treecore changed the title [NEW] Form / InputSelect [NEW] Form / Select Field Oct 19, 2021
@neveraemje
Copy link

neveraemje commented Nov 1, 2021 •
edited by zanuarmirza
Loading

Select Tag

  • onFocus style tidak hilang ketika onBlur (refers styling dari select search udah oke)
  • Apakah possible saat pilih select field muncul semua isi droprown tanpa harus searching dulu? (behavior select default)

Select Search

  • Apakah possible saat pilih select field muncul semua isi droprown tanpa harus searching dulu? (behavior select default)

Select

  • border State focus and active belum sesuai. (refers styling dari select search udah oke)
  • padding horizontal 12px

@IzzanNurdin @DioSyahrizal @resir014

@resir014 resir014 mentioned this issue Nov 6, 2021
Merged
@zanuarmirza zanuarmirza reopened this Nov 8, 2021
@zanuarmirza zanuarmirza self-assigned this Nov 8, 2021
resir014 added a commit that referenced this issue Nov 9, 2021
@resir014
fix(react): fix focus variants on select tags
593bac8 
Fixes #451.
@resir014 resir014 mentioned this issue Nov 9, 2021
Merged
zanuarmirza pushed a commit that referenced this issue Nov 10, 2021
@resir014
fix(react): fix focus variants on select tags (#563)
480f322 
* fix(react): fix focus variants on select tags

Fixes #451.

* fix(react): remove unused hook state variable
@zanuarmirza zanuarmirza reopened this Nov 10, 2021
@zanuarmirza zanuarmirza mentioned this issue Nov 10, 2021
Merged
@neveraemje
Copy link

neveraemje commented Nov 25, 2021 •
edited by zanuarmirza
Loading

TODO

25 Nov 2021

@neveraemje
Copy link

neveraemje commented Nov 29, 2021 •
edited
Loading

  • Padding kanan 12 px @zanuarmirza
  • space select field between select item 4px

@zanuarmirza zanuarmirza mentioned this issue Nov 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@resir014 resir014

@zanuarmirza zanuarmirza

@DioSyahrizal DioSyahrizal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
4 participants
@resir014 @neveraemje @zanuarmirza @DioSyahrizal