Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): toast rewrite #426

Merged
merged 9 commits into from
Sep 1, 2021
Merged

feat(react): toast rewrite #426

merged 9 commits into from
Sep 1, 2021

Conversation

resir014
Copy link
Contributor

Closes #421.

@vercel
Copy link

vercel bot commented Aug 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kata-ai/aksara-ui/3s9VosLvDxD8zjKpajNssD6t4WxW
✅ Preview: https://aksara-ui-git-refactor-toast-20-kata-ai.vercel.app

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #426 (1b0df2f) into master (b471544) will decrease coverage by 2.66%.
The diff coverage is n/a.

❗ Current head 1b0df2f differs from pull request most recent head d0be8f0. Consider uploading reports for the commit d0be8f0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
- Coverage   75.45%   72.78%   -2.67%     
==========================================
  Files         136      143       +7     
  Lines        1051     1117      +66     
  Branches      264      278      +14     
==========================================
+ Hits          793      813      +20     
- Misses        258      304      +46     
Impacted Files Coverage Δ
src/aksara-provider/AksaraProvider.tsx 100.00% <0.00%> (ø)
src/components/toast/internals/ToastProvider.tsx 41.17% <0.00%> (ø)
src/components/toast/internals/constants.ts 100.00% <0.00%> (ø)
src/components/toast/Toast.tsx 11.11% <0.00%> (ø)
src/components/toast/internals/ToastContext.tsx 100.00% <0.00%> (ø)
src/components/toast/internals/ToastContainer.tsx 60.00% <0.00%> (ø)
src/components/toast/useToast.ts 0.00% <0.00%> (ø)
src/theme/componentStyles/toast.ts 75.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b471544...d0be8f0. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UPDATE] Toast
1 participant