Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): add newly design modal #485

Merged
merged 3 commits into from
Sep 28, 2021
Merged

feat(react): add newly design modal #485

merged 3 commits into from
Sep 28, 2021

Conversation

DioSyahrizal
Copy link
Contributor

Relate #417

@vercel
Copy link

vercel bot commented Sep 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kata-ai/aksara-ui/GzGtE15GtfU8BTZ5vQodfgUjSvBU
✅ Preview: https://aksara-ui-git-feat-modal-kata-ai.vercel.app

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #485 (694f2cf) into master (d066263) will decrease coverage by 0.31%.
The diff coverage is n/a.

❗ Current head 694f2cf differs from pull request most recent head c1e60dd. Consider uploading reports for the commit c1e60dd to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   69.16%   68.85%   -0.32%     
==========================================
  Files         147      148       +1     
  Lines        1226     1233       +7     
  Branches      331      331              
==========================================
+ Hits          848      849       +1     
- Misses        378      384       +6     
Impacted Files Coverage Δ
src/components/dialog/components/DialogFooter.tsx 0.00% <0.00%> (ø)
src/components/dialog/components/DialogHeader.tsx 0.00% <0.00%> (ø)
src/components/dialog/components/DialogContent.tsx 0.00% <0.00%> (ø)
src/components/dialog/components/DialogOverlay.tsx 100.00% <0.00%> (ø)
src/components/dialog/components/Dialog.tsx
...c/components/dialog/components/ModalHeaderIcon.tsx 0.00% <0.00%> (ø)
src/components/dialog/components/Modal.tsx 78.84% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d066263...c1e60dd. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
22.1% 22.1% Duplication

@resir014 resir014 merged commit a521756 into master Sep 28, 2021
@resir014 resir014 deleted the feat/modal branch September 28, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants