Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(table): new table storybook #546

Merged
merged 11 commits into from
Nov 1, 2021
Merged

Conversation

stevenevan
Copy link
Contributor

@stevenevan stevenevan commented Nov 1, 2021

Closes #429

Current Tasks

  • Remove table stories remaining
  • Make new story which similar to figma design (dynamic component) + checkbox selected

New story
image

Selected & Sort
image

@vercel
Copy link

vercel bot commented Nov 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kata-ai/aksara-ui/ByfupnYviA48fNsXdXfzCkTT2Mar
✅ Preview: https://aksara-ui-git-chore-fix-table-storybook-kata-ai.vercel.app

@stevenevan stevenevan changed the title Chore(table): fix table storybook docs(table): fix table storybook Nov 1, 2021
@stevenevan stevenevan changed the title docs(table): fix table storybook docs(table): new table storybook Nov 1, 2021
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #546 (5f10224) into master (73d561b) will increase coverage by 0.34%.
The diff coverage is n/a.

❗ Current head 5f10224 differs from pull request most recent head ec29633. Consider uploading reports for the commit ec29633 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
+ Coverage   58.48%   58.82%   +0.34%     
==========================================
  Files         170      170              
  Lines        1544     1535       -9     
  Branches      447      446       -1     
==========================================
  Hits          903      903              
+ Misses        641      632       -9     
Impacted Files Coverage Δ
src/components/table/makeData.ts
src/components/table/data.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d561b...ec29633. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Nov 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@IzzanNurdin IzzanNurdin merged commit a322f44 into master Nov 1, 2021
@IzzanNurdin IzzanNurdin deleted the chore/fix-table-storybook branch November 1, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UPDATE] Table
2 participants