Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: modal, sidesheet #647

Merged
merged 7 commits into from
Dec 20, 2021
Merged

refactor: modal, sidesheet #647

merged 7 commits into from
Dec 20, 2021

Conversation

zanuarmirza
Copy link
Contributor

Closes #580
Closes #417
Closes #573
Closes #574

@vercel
Copy link

vercel bot commented Dec 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kata-ai/aksara-ui/CC8R6UtzQ47nkb1RQT9G5r4vNMen
✅ Preview: https://aksara-ui-git-refactor-modal-kata-ai.vercel.app

@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
23.5% 23.5% Duplication

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #647 (e4a0e4e) into master (41c4a70) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
+ Coverage   59.90%   60.08%   +0.18%     
==========================================
  Files         197      195       -2     
  Lines        1808     1809       +1     
  Branches      530      539       +9     
==========================================
+ Hits         1083     1087       +4     
+ Misses        725      722       -3     
Impacted Files Coverage Δ
src/components/side-sheet/components/SideSheet.tsx 75.55% <0.00%> (-1.53%) ⬇️
...c/components/dialog/components/ModalHeaderIcon.tsx
src/components/dialog/components/DialogContent.tsx
src/components/dialog/components/DialogHeader.tsx
src/components/dialog/constants.ts
...mponents/side-sheet/components/SideSheetFooter.tsx
src/components/dialog/components/Modal.tsx
...mponents/side-sheet/components/SideSheetHeader.tsx
src/components/dialog/components/DialogFooter.tsx
src/components/dialog/components/DialogOverlay.tsx
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41c4a70...e4a0e4e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal Overlay Footer Header [UPDATE] Modal
1 participant