Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

TestContainerAddResources fails #192

Closed
devimc opened this issue Apr 5, 2018 · 0 comments · Fixed by #193
Closed

TestContainerAddResources fails #192

devimc opened this issue Apr 5, 2018 · 0 comments · Fixed by #193
Assignees
@devimc

Comments

@devimc
Copy link

devimc commented Apr 5, 2018 

--- FAIL: TestContainerAddResources (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x50 pc=0xc87264]

goroutine 132 [running]:
testing.tRunner.func1(0xc42020e960)
	/usr/local/go/src/testing/testing.go:711 +0x5d9
panic(0xe526a0, 0x15a2340)
	/usr/local/go/src/runtime/panic.go:491 +0x2a2
github.com/kata-containers/runtime/virtcontainers.(*Container).addResources(0xc42047de58, 0x118, 0x0)
	github.com/kata-containers/runtime/virtcontainers/_test/_obj_test/container.go:935 +0x394
github.com/kata-containers/runtime/virtcontainers.TestContainerAddResources(0xc42020e960)
	/home/jenkins/jenkins_slave/workspace/kata-containers-runtime-ubuntu-16-04-PR/go/src/github.com/kata-containers/runtime/virtcontainers/container_test.go:311 +0x5a3
testing.tRunner(0xc42020e960, 0xf4e4c0)
	/usr/local/go/src/testing/testing.go:746 +0x16d
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:789 +0x569
exit status 2
@devimc devimc self-assigned this Apr 5, 2018
devimc pushed a commit to devimc/kata-runtime that referenced this issue Apr 5, 2018
virtcontainers: container: fix TestContainerAddResources unit test
5153ad2 
use nooAgent in unit tests to add online fake resources

fixes kata-containers#192

Signed-off-by: Julio Montes <[email protected]>
@devimc devimc mentioned this issue Apr 5, 2018
Merged
@devimc devimc added the review label Apr 5, 2018
devimc pushed a commit to devimc/kata-runtime that referenced this issue Apr 5, 2018
virtcontainers: container: fix TestContainerAddResources unit test
65bb7ec 
use noopAgent in unit tests to add online fake resources

fixes kata-containers#192

Signed-off-by: Julio Montes <[email protected]>
devimc pushed a commit to devimc/kata-runtime that referenced this issue Apr 5, 2018
virtcontainers: fix unit tests
89f8c69 
Use noopAgent in unit tests to add online fake resources.
Fix unit tests according with new changes introduced recently.

fixes kata-containers#192

Signed-off-by: Julio Montes <[email protected]>
devimc pushed a commit to devimc/kata-runtime that referenced this issue Apr 5, 2018
virtcontainers: fix unit tests
62220a4 
Use noopAgent in unit tests to add online fake resources.
Fix unit tests according with new changes introduced recently.

fixes kata-containers#192

Signed-off-by: Julio Montes <[email protected]>
devimc pushed a commit to devimc/kata-runtime that referenced this issue Apr 5, 2018
virtcontainers: fix unit tests
92fa5e9 
Use noopAgent in unit tests to add online fake resources.
Fix unit tests according with new changes introduced recently.

fixes kata-containers#192

Signed-off-by: Julio Montes <[email protected]>
devimc pushed a commit to devimc/kata-runtime that referenced this issue Apr 5, 2018
virtcontainers: fix unit tests
cde11c3 
Use noopAgent in unit tests to add online fake resources.
Fix unit tests according with new changes introduced recently.

fixes kata-containers#192

Signed-off-by: Julio Montes <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Apr 7, 2018
@bergwolf
vendor: udpate agent dependency
0a49daf 
To include the grpc yamux dialer.

Included kata agent git shortlog:
Archana Shinde (1):
      mount: Correct error message with mount failure.

Eric Ernst (2):
      Merge pull request kata-containers#196 from sboeuf/fix_rollback
      Merge pull request kata-containers#201 from bergwolf/yamux_client

Graham whaley (1):
      ci: lib: allow override of tests_repo

James O. D. Hunt (16):
      mount: Log params and validate
      device: Add validation and debug
      tests: Move helper function
      tests: Use root skip function
      tests: Skip more tests if non-root
      CI: Require pullapprove ack for protocol changes
      agent: Add announce function
      announce: Add standard fields when running as PID 1
      announce: Add device and storage handlers
      announce: Add total memory
      Merge pull request kata-containers#180 from jodh-intel/add-announce-log-call
      github: Add issue template
      Merge pull request kata-containers#189 from grahamwhaley/20180322_tests_repo
      Merge pull request kata-containers#187 from jodh-intel/github-issue-template
      Merge pull request kata-containers#192 from sboeuf/fix_device
      Merge pull request kata-containers#197 from amshinde/correct-err-msg

Lai Jiangshan (1):
      Merge pull request kata-containers#176 from jodh-intel/pullapprove-for-grpc-changes

Peng Tao (3):
      Merge pull request kata-containers#171 from jodh-intel/validate-mount-params
      Merge pull request kata-containers#206 from sboeuf/fix_rollback
      protocol: client: enable builtin yamux client support

Sebastien Boeuf (7):
      Merge pull request kata-containers#178 from jodh-intel/skip-more-tests-if-not-root
      Merge pull request kata-containers#173 from jodh-intel/add-device-debug
      device: VmPath can be empty if an Id is provided
      agent: Rollback properly when container creation fails
      vendor: Update libcontainer vendoring
      Merge pull request kata-containers#203 from sboeuf/revendor_libcontainer
      agent: Fix container creation rollback

Signed-off-by: Peng Tao <[email protected]>
@sboeuf sboeuf removed the review label Apr 9, 2018
zklei pushed a commit to zklei/runtime that referenced this issue Jun 13, 2019
@jodh-intel
Merge pull request kata-containers#192 from sboeuf/fix_device
21a015b 
device: VmPath can be empty if an Id is provided
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devimc devimc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

virtcontainers: fix unit tests devimc/kata-runtime
2 participants
@devimc @sboeuf