This repository has been archived by the owner on May 12, 2021. It is now read-only.
make install does not (re)build #283
Comments
stefanha
pushed a commit
to stefanha/runtime
that referenced
this issue
May 2, 2018
"make install" fails on a clean working directory: $ make install install: cannot stat ‘data/kata-collect-data.sh’: No such file or directory This happens because install and install-scripts do not depend on the runtime. Make doesn't know it needs to build the runtime before it can be installed. Add the missing dependencies to the install targets so that "make install" works on a clean working directory and rebuilds when source files have been modified. Note that SCRIPTS contains the generated kata-collect-data.sh script. That file needs to be generated before it can be installed, so make SCRIPTS a dependency of install-scripts. Fixes: kata-containers#283 Signed-off-by: Stefan Hajnoczi <[email protected]>
zklei
pushed a commit
to zklei/runtime
that referenced
this issue
Jun 13, 2019
CloseStdin() is supposed to close only the standard input, which helps the process to terminate in some cases. But for the case where we are using a terminal, it should be closed by the agent once the WaitProcess() will complete. Otherwise, closing it before the end of the process could prevent some output from the terminal to reach the shim. Fixes kata-containers#283 Signed-off-by: Sebastien Boeuf <[email protected]>
zklei
pushed a commit
to zklei/runtime
that referenced
this issue
Jun 13, 2019
After CloseStdin() has been invoked, there is no reason to accept writing to stdin anymore. Instead, we can simply ignore those calls. Fixes kata-containers#283 Signed-off-by: Sebastien Boeuf <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description of problem
"make install" fails on a clean working directory:
This happens because install and install-scripts do not depend on the
runtime. Make doesn't know it needs to build the runtime before it can
be installed.
Expected result
"make install" builds the runtime and then installs the files successfully.
Actual result
install: cannot stat ‘data/kata-collect-data.sh’: No such file or directory
The text was updated successfully, but these errors were encountered: