api: add sandbox hotplug network #287

caoruidong · 2018-05-07T14:50:08Z

Fixes #113
Refactor generate interface and route, add network hotplug interface

Signed-off-by: Ruidong Cao [email protected]

codecov · 2018-05-08T05:55:19Z

Codecov Report

Merging #287 into master will decrease coverage by 0.05%.
The diff coverage is 53.26%.

@@            Coverage Diff            @@
##           master    #287      +/-   ##
=========================================
- Coverage   64.76%   64.7%   -0.06%     
=========================================
  Files          83      84       +1     
  Lines        9178    9551     +373     
=========================================
+ Hits         5944    6180     +236     
- Misses       2620    2723     +103     
- Partials      614     648      +34

egernst · 2018-05-15T04:37:22Z

@sboeuf - can you PTAL?

bergwolf · 2018-05-15T13:29:08Z

Generally looks good. Can you please add cli side change so that these APIs are actually used and tested?

devimc · 2018-05-15T13:53:10Z

virtcontainers/agent.go

@@ -194,4 +195,13 @@ type agent interface {
 	// This function should be called after hot adding vCPUs or Memory.
 	// cpus specifies the number of CPUs that were added and the agent should online
 	onlineCPUMem(cpus uint32) error
+
+	// hotPlugNetwork will tell the agent to add a new nic for an existed Sandbox.


s/hotPlugNetwork/plugRoutes

devimc · 2018-05-15T13:53:42Z

virtcontainers/agent.go

+	// hotPlugNetwork will tell the agent to add a new nic for an existed Sandbox.
+	hotPlugNetwork(sandbox *Sandbox, endpoint Endpoint) error
+
+	// hotPlugNetwork will tell the agent to del a new nic for an existed Sandbox.


s/hotPlugNetwork/hotPullNetwork

To support tap network hotplug. Implement netdev_add, netdev_del and corresponding device_add QMP commands. Full list in govmm: 10efa84 qemu/qmp: add function for hotplug network by fds 80ed88e qemu/qmp: implement function to hotplug serial ports ca46f21 qemu/qmp: implement function to hotplug character devices 03f1a1c qemu/qmp: implement getfd 84b212f qemu: add vhostfd and disable-modern to vsock hotplug 12dfa87 qemu/qmp: implement function for hotplug network 4ca232e qmp_test: Fix Warning and Error level logs 430e72c qemu,qmp: Enable gas security checker ffc06e6 qemu,qmp: Add staticcheck to travis and fix errors Add agent ListInterfaces and ListRoutes APIs. Full list in agent: 7c287c6 agent: add ListInterfaces and ListRoutes rpc Signed-off-by: Ruidong Cao <[email protected]>

Add sandbox hotplug network API to meet design Signed-off-by: Ruidong Cao <[email protected]>

Add update and list commands for notwork hotplug Signed-off-by: Ruidong Cao <[email protected]>

opendev-zuul · 2018-08-16T09:11:55Z

Build succeeded (third-party-check pipeline).

kata-runsh : SUCCESS in 54m 35s

WeiZhang555 · 2018-08-16T09:47:24Z

LGTM

I'd prefer to keep the network monitor solution a very specific one, only in case we want to detect network changes. But this monitoring process increases the footprint of the whole system, and might not be reliable for now in case of crash/restart. What I would suggest is that we can configure from configuration.toml if we want the network monitoring process or not. Based on this, we would either start the monitoring process before the OCI hooks from the CLI, or we would simply scan the netns from the CLI.
Does that make sense ?

I think this could make sense :-) @sboeuf

add UTs for network hotplug related fuctions Fixes kata-containers#113 Signed-off-by: Ruidong Cao <[email protected]>

katacontainersbot · 2018-08-16T13:41:28Z

PSS Measurement:
Qemu: 169758 KB
Proxy: 4247 KB
Shim: 8959 KB

Memory inside container:
Total Memory: 2043464 KB
Free Memory: 2003760 KB

caoruidong · 2018-08-16T14:24:05Z

@sboeuf I add some tests. Please check if this is right

sboeuf · 2018-08-16T14:41:05Z

@caoruidong thank you very much!
I'll review and merge if everything's good :)

opendev-zuul · 2018-08-16T15:05:57Z

Build succeeded (third-party-check pipeline).

kata-runsh : SUCCESS in 56m 53s

sboeuf

LGTM

sboeuf · 2018-08-16T15:19:31Z

Merging as -0.06% coverage is clearly negligible here.

CaesarLXL · 2018-08-20T01:04:17Z

This feature is currently not valid because the pull request 534 is not fully implemented.

caoruidong force-pushed the hotplug branch 7 times, most recently from 996402e to 1535dda Compare May 8, 2018 05:55

caoruidong force-pushed the hotplug branch 13 times, most recently from c26214a to 82dd787 Compare May 13, 2018 13:35

caoruidong changed the title ~~[WIP] API: add network hotplug~~ api: add sanbox hotplug network May 14, 2018

egernst requested a review from sboeuf May 15, 2018 04:37

caoruidong force-pushed the hotplug branch 3 times, most recently from 3b02c60 to 685aa44 Compare May 15, 2018 07:52

devimc reviewed May 15, 2018

View reviewed changes

caoruidong force-pushed the hotplug branch from 5d64559 to 6b0bb4e Compare August 16, 2018 07:48

kata-containers deleted a comment from katacontainersbot Aug 16, 2018

kata-containers deleted a comment from opendev-zuul bot Aug 16, 2018

kata-containers deleted a comment from katacontainersbot Aug 16, 2018

kata-containers deleted a comment from opendev-zuul bot Aug 16, 2018

caoruidong added 3 commits August 16, 2018 16:06

virtcontainers: add sandbox hotplug network API

1a17200

Add sandbox hotplug network API to meet design Signed-off-by: Ruidong Cao <[email protected]>

cli: add network commands

72df219

Add update and list commands for notwork hotplug Signed-off-by: Ruidong Cao <[email protected]>

caoruidong force-pushed the hotplug branch from 6b0bb4e to 8eed692 Compare August 16, 2018 08:12

kata-containers deleted a comment from katacontainersbot Aug 16, 2018

kata-containers deleted a comment from opendev-zuul bot Aug 16, 2018

WeiZhang555 approved these changes Aug 16, 2018

View reviewed changes

devimc approved these changes Aug 16, 2018

View reviewed changes

test: add UTs for network hotplug

7beb309

add UTs for network hotplug related fuctions Fixes kata-containers#113 Signed-off-by: Ruidong Cao <[email protected]>

caoruidong force-pushed the hotplug branch from 8eed692 to 7beb309 Compare August 16, 2018 13:32

sboeuf reviewed Aug 16, 2018

View reviewed changes

sboeuf merged commit 26f3107 into kata-containers:master Aug 16, 2018

caoruidong deleted the hotplug branch August 17, 2018 02:23

sboeuf added the feature New functionality label Sep 12, 2018

kata-containers deleted a comment from katacontainersbot Nov 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

api: add sandbox hotplug network #287

api: add sandbox hotplug network #287

caoruidong commented May 7, 2018

codecov bot commented May 8, 2018 •

edited

Loading

egernst commented May 15, 2018

bergwolf commented May 15, 2018

devimc May 15, 2018

devimc May 15, 2018 •

edited

Loading

caoruidong May 15, 2018

opendev-zuul bot commented Aug 16, 2018

WeiZhang555 commented Aug 16, 2018

katacontainersbot commented Aug 16, 2018

caoruidong commented Aug 16, 2018

sboeuf commented Aug 16, 2018

opendev-zuul bot commented Aug 16, 2018

sboeuf left a comment

sboeuf commented Aug 16, 2018

CaesarLXL commented Aug 20, 2018

api: add sandbox hotplug network #287

api: add sandbox hotplug network #287

Conversation

caoruidong commented May 7, 2018

codecov bot commented May 8, 2018 • edited Loading

Codecov Report

egernst commented May 15, 2018

bergwolf commented May 15, 2018

devimc May 15, 2018

Choose a reason for hiding this comment

devimc May 15, 2018 • edited Loading

Choose a reason for hiding this comment

caoruidong May 15, 2018

Choose a reason for hiding this comment

opendev-zuul bot commented Aug 16, 2018

WeiZhang555 commented Aug 16, 2018

katacontainersbot commented Aug 16, 2018

caoruidong commented Aug 16, 2018

sboeuf commented Aug 16, 2018

opendev-zuul bot commented Aug 16, 2018

sboeuf left a comment

Choose a reason for hiding this comment

sboeuf commented Aug 16, 2018

CaesarLXL commented Aug 20, 2018

codecov bot commented May 8, 2018 •

edited

Loading

devimc May 15, 2018 •

edited

Loading