This repository has been archived by the owner on May 12, 2021. It is now read-only.
virtcontainers: Add missing API release calls #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
|
OOI, how did you notice this issue? I guess we can't create any tests for this? |
|
@jodh-intel Recently I'm making some changes to network. What happens without release？Will they be released after runtime exit？ |
|
Yes - |
Codecov Report
@@ Coverage Diff @@
## master #830 +/- ##
=========================================
+ Coverage 66.09% 66.1% +0.01%
=========================================
Files 87 87
Lines 10505 10509 +4
=========================================
+ Hits 6943 6947 +4
Misses 2863 2863
Partials 699 699 |
Add missing release sandbox calls to network related functions in virtcontainers API. Fixes kata-containers#732. Signed-off-by: Ruidong Cao <[email protected]>
|
LGTM. nice catch~ |
|
LGTM! |
|
boot time and memory footprint metrics failures are known issues. Let's ignore it here. |
egernst
pushed a commit
to egernst/runtime
that referenced
this pull request
Feb 9, 2021
network: Fix Could not create destination mount point: /etc/resolv.conf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing release sandbox calls to network related functions in
virtcontainers API.
Fixes #732.
Signed-off-by: Ruidong Cao [email protected]