fixed code quality issues #1694
Conversation
|
|
| @@ -210,7 +210,7 @@ func (g *Group) Error() (s string) { | |||
| } | |||
|
|
|||
| func (g *Group) getAllErrors() []error { | |||
| list := g.Errors[:] | |||
| list := g.Errors | |||
There was a problem hiding this comment.
I don't think this change is equivocal.
There was a problem hiding this comment.
Hey @AlbinoGeek
I am not sure what you mean. You can have a look at the description of the issue being resolved here.
|
@withshubh I've added deepsource on this repository as well, I didn't know you are part of their team, good job mate. However, not all provided "fixes" are really fixes, Go support is not totally completed yet, right? |
|
@kataras Thanks 💖 DeepSource Go analyzer identifies more than 200+ code quality issues and supports autofix for most commonly occurring issues. Our team actively updates all the analyzers with new rules. Learn more about Go analyzer here. Regarding the fixes, the first two fixes the anti-patterns while the third one boosts minor performance. Also, If you have suggestions regarding the improvement of our Go analyzer then you can post them in the slack user group or in the DeepSource Community Forum. |
* Combine multiple `append`s into a single call * Remove unnecessary use of slice * Replace `strings.Index` with `strings.Contains` * Added .deepsource.toml config file for DeepSource integration
|
I've already joined to the slack @withshubh ^_^ but I don't have enough time lately to integrate with you guys yet :/ Your product looks legit and very promising though, good job! |
Thanks! @kataras ✨ 💖 |
Summary of Changes
strings.Indexwithstrings.Containsappends into a single call