Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifiy DirList's default html format #1717

Merged
merged 2 commits into from
Jan 31, 2021
Merged

Conversation

tuhao1020
Copy link
Contributor

@tuhao1020 tuhao1020 commented Jan 28, 2021

  1. add DirOptions.ShowHidden option to show hidden files or directories or not
  2. modify DirList's default html format
  • use <div> instead of <pre>
  • use <ul> and <li> for file/directory list
  • add a link to parent directory
  • display current directory
  • display file mode string

Copy link
Owner

@kataras kataras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tuhao1020 good job! Can I ask if you tried this one with embedded files as well? If it's working fine there I think we are ready to merge it

@tuhao1020
Copy link
Contributor Author

@kataras yes, I've tested embedded files using go-bindata, it's also working

@kataras
Copy link
Owner

kataras commented Jan 31, 2021

@tuhao1020 OK that's nice but we have our own version of caching too, I will merge it but whenever you find time please test the Iris FS Cache too (

func cache(fs http.FileSystem, options DirCacheOptions) (*cacheFS, error) {
).

@kataras kataras merged commit 07b30e5 into kataras:master Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants